Skip to content

Conversation

@dsoffiantini
Copy link
Contributor

Description

Updates circleci xcode build version to 13, adds workaround to deal with circleci xcode naming. See linked issue for details.

Related Issue

#196

Motivation and Context

The current xcode version in the build will be deprecated on Aug 2, and all ios builds will fail afterwards.

How Has This Been Tested?

Ran successfully in CircleCI!

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dsoffiantini dsoffiantini changed the base branch from main to staging July 28, 2022 17:55
Copy link
Contributor

@yangyansong-adbe yangyansong-adbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for fixing the issue.

@dsoffiantini dsoffiantini merged commit 91b9178 into staging Jul 29, 2022
@dsoffiantini dsoffiantini deleted the circleci-update-xcode branch July 29, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants