Use new API of PID class #1410
Merged
Use new API of PID class #1410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@christophfroehlich we have fixed the semi-binary pipeline, so rebasing this as soon as ros-controls/control_toolbox#400 is merged, should succeed :-) |
christophfroehlich
force-pushed
the
sjtc/pid
branch
from
be7d68c to
efa9534
Compare
|
still needs ros-controls/ros2_controllers#1759 |
|
PRs for control_toolbox+ros2_controllers got merged to rolling, kilted, jazzy, and will be released soon-ish. |
Awesome! I'll re-run the semi-binary builds. |
|
The only test failing is a flaky test, that should be unrelated to this. |
mergify bot
pushed a commit
that referenced
this pull request
Jun 18, 2025
* Use new API of PID class * Add error_deadband (cherry picked from commit 56dfa1e)
urfeex
pushed a commit
that referenced
this pull request
Jun 18, 2025
* Use new API of PID class * Add error_deadband Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once ros-controls/ros2_controllers#1759 and ros-controls/control_toolbox#400 is merged.
Fixes ros-controls/control_toolbox#392