-
Notifications
You must be signed in to change notification settings - Fork 575
Briancoughlin patch 2 #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkrell
reviewed
Apr 6, 2021
Contributor
lkrell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick feedback
Contributor
|
This should be merged after your other fix is merged |
Co-authored-by: Lori Krell <[email protected]>
Contributor
Author
|
have added the changes for the other PR ( Github was mucking about earlier so it lost my initial PR so i redid it ). everything should be in this one now. |
SamuelBellomo
approved these changes
Apr 6, 2021
pdeschain
approved these changes
Apr 6, 2021
lkrell
approved these changes
Apr 6, 2021
SamuelBellomo
added a commit
that referenced
this pull request
May 19, 2021
* main: Adding suggested changes Uploading pull-request-template docs: License UCL update and changelog additions (#304) Correction for stealth state, should use bool, not byte (#263) Create third-party contributions file (#262) Update README.md in package (#260) Architecture.md improvements (#254) docs: Changelog and Third Party for 0.1.0 (#233) Update LICENSE.md Update LICENSE.md Update LICENSE.md adding initial codeowners file (sam as global) (#258) Update readme (#256) Adding missing space project name update (#245) quick fix for missing TGA # Conflicts: # Assets/BossRoom/Scripts/Client/Game/Character/ClientCharacterVisualization.cs # Assets/BossRoom/Scripts/Server/Game/Action/StealthModeAction.cs # Assets/BossRoom/Scripts/Server/Game/Character/AIBrain.cs # Packages/com.unity.multiplayer.samples.coop/CHANGELOG.md # ProjectSettings/ProjectSettings.asset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested updates to the readme based on information gained writing the getting-started guide.