Refactor for stealth state, should use bool, not byte #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelBellomo
added
0-URGENT
LukeStampfli
approved these changes
Apr 7, 2021
Contributor
LukeStampfli
left a comment
LukeStampfli
left a comment
There was a problem hiding this comment.
Confirm that this works no in MLAPI, the refactor is correct and the comments have been correctly removed.
LukeStampfli
added
2-One More Review
pdeschain
approved these changes
Apr 7, 2021
pdeschain
added
3-Good to Merge
and removed
2-One More Review
Contributor
|
@SamuelBellomo Did this get merged into the intended branch? I think it should be in |
Contributor
Author
@fernando-cortez will look into merging master back to develop. |
SamuelBellomo
added a commit
that referenced
this pull request
May 19, 2021
* main: Adding suggested changes Uploading pull-request-template docs: License UCL update and changelog additions (#304) Correction for stealth state, should use bool, not byte (#263) Create third-party contributions file (#262) Update README.md in package (#260) Architecture.md improvements (#254) docs: Changelog and Third Party for 0.1.0 (#233) Update LICENSE.md Update LICENSE.md Update LICENSE.md adding initial codeowners file (sam as global) (#258) Update readme (#256) Adding missing space project name update (#245) quick fix for missing TGA # Conflicts: # Assets/BossRoom/Scripts/Client/Game/Character/ClientCharacterVisualization.cs # Assets/BossRoom/Scripts/Server/Game/Action/StealthModeAction.cs # Assets/BossRoom/Scripts/Server/Game/Character/AIBrain.cs # Packages/com.unity.multiplayer.samples.coop/CHANGELOG.md # ProjectSettings/ProjectSettings.asset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This missing fix slipped through and gives the wrong message that NetworkVariableBool is broken (which is not the case). Removing that usage now to not mislead users.