Skip to content

Architecture.md improvements #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Apr 6, 2021
Merged

Architecture.md improvements #254

merged 20 commits into from
Apr 6, 2021

Conversation

@pdeschain
Copy link
Contributor

@pdeschain pdeschain commented Apr 6, 2021

No description provided.

@lkrell lkrell self-requested a review April 6, 2021 14:37
@pdeschain pdeschain added the 1-Needs Review PR needs attention from the assignee and reviewers label Apr 6, 2021
@SamuelBellomo SamuelBellomo added the 0-URGENT Blocker for a release and needs to be merged ASAP label Apr 6, 2021
@unity-cla-assistant
Copy link

unity-cla-assistant commented Apr 6, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

lkrell
lkrell reviewed Apr 6, 2021
View reviewed changes
Copy link
Contributor

@lkrell lkrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additions! Some edits to consider! One definitely may want to be changed for NetworkedVars to NetworkVariables.

pdeschain and others added 7 commits April 6, 2021 13:35
@pdeschain @lkrell
Update ARCHITECTURE.md
3d085d9 
Co-authored-by: Lori Krell <[email protected]>
@pdeschain @lkrell
Update ARCHITECTURE.md
6cc84f5 
Co-authored-by: Lori Krell <[email protected]>
@pdeschain @lkrell
Update ARCHITECTURE.md
50ed792 
Co-authored-by: Lori Krell <[email protected]>
@pdeschain @lkrell
Update ARCHITECTURE.md
73d46ad 
Co-authored-by: Lori Krell <[email protected]>
@pdeschain @lkrell
Update ARCHITECTURE.md
f6ff651 
Co-authored-by: Lori Krell <[email protected]>
@pdeschain @lkrell
Update ARCHITECTURE.md
6cafd82 
Co-authored-by: Lori Krell <[email protected]>
@pdeschain @lkrell
Update ARCHITECTURE.md
8a28bff 
Co-authored-by: Lori Krell <[email protected]>
SamuelBellomo
SamuelBellomo reviewed Apr 6, 2021
View reviewed changes
pdeschain and others added 2 commits April 6, 2021 14:00
@pdeschain @lkrell
Update ARCHITECTURE.md
29d64fd 
Co-authored-by: Lori Krell <[email protected]>
@pdeschain @SamuelBellomo
Update ARCHITECTURE.md
bced46c 
Co-authored-by: Sam Bellomo <[email protected]>
lkrell
lkrell previously approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@lkrell lkrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

SamuelBellomo
SamuelBellomo reviewed Apr 6, 2021
View reviewed changes
SamuelBellomo
SamuelBellomo reviewed Apr 6, 2021
View reviewed changes
SamuelBellomo
SamuelBellomo reviewed Apr 6, 2021
View reviewed changes
@pdeschain @SamuelBellomo
Update ARCHITECTURE.md
abbb1c9 
Co-authored-by: Sam Bellomo <[email protected]>
pdeschain and others added 3 commits April 6, 2021 16:08
@pdeschain @SamuelBellomo
Update ARCHITECTURE.md
a9d0cee 
Co-authored-by: Sam Bellomo <[email protected]>
@pdeschain @SamuelBellomo
Update ARCHITECTURE.md
11ba9f3 
Co-authored-by: Sam Bellomo <[email protected]>
@pdeschain
Merge branch 'release/v0.1.0-experimental' of github.com:Unity-Techno…
7974f98 
…logies/com.unity.multiplayer.samples.coop into feature/architecture-md-improvements

# Conflicts:
#	ARCHITECTURE.md
lkrell
lkrell previously approved these changes Apr 6, 2021
View reviewed changes
@SamuelBellomo SamuelBellomo merged commit 709a8bb into release/v0.1.0-experimental Apr 6, 2021
@SamuelBellomo SamuelBellomo deleted the feature/architecture-md-improvements branch April 6, 2021 21:57
SamuelBellomo added a commit that referenced this pull request Apr 6, 2021
@SamuelBellomo
Merge branch 'release/v0.1.0-experimental' into master
bfb2a46 
* release/v0.1.0-experimental:
  Architecture.md improvements (#254)
  docs: Changelog and Third Party for 0.1.0  (#233)
  Update LICENSE.md
SamuelBellomo added a commit that referenced this pull request May 19, 2021
@SamuelBellomo
Merge branch 'main' into develop
a023663 
* main:
  Adding suggested changes
  Uploading pull-request-template
  docs: License UCL update and changelog additions (#304)
  Correction for stealth state, should use bool, not byte (#263)
  Create third-party contributions file (#262)
  Update README.md in package (#260)
  Architecture.md improvements (#254)
  docs: Changelog and Third Party for 0.1.0  (#233)
  Update LICENSE.md
  Update LICENSE.md
  Update LICENSE.md
  adding initial codeowners file (sam as global) (#258)
  Update readme (#256)
  Adding missing space
  project name update (#245)
  quick fix for missing TGA

# Conflicts:
#	Assets/BossRoom/Scripts/Client/Game/Character/ClientCharacterVisualization.cs
#	Assets/BossRoom/Scripts/Server/Game/Action/StealthModeAction.cs
#	Assets/BossRoom/Scripts/Server/Game/Character/AIBrain.cs
#	Packages/com.unity.multiplayer.samples.coop/CHANGELOG.md
#	ProjectSettings/ProjectSettings.asset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

+1 more reviewer

@lkrell lkrell lkrell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pdeschain pdeschain

@SamuelBellomo SamuelBellomo

Labels

0-URGENT Blocker for a release and needs to be merged ASAP 1-Needs Review PR needs attention from the assignee and reviewers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pdeschain @unity-cla-assistant @SamuelBellomo @lkrell