Fix and speed up top helper anticheat #659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sped up uncounted char matching by compiling the pattern once and using the pattern to replace chars instead of passing the RegEx string to String#replaceAll which would compile the pattern every time
|
You know, thats why one should write unit tests 🙂 |
Zabuzard
approved these changes
Oct 25, 2022
|
considering this critical, since we must not release until this is merged. otherwise the top helper system is dead until the next release |
Should I add one? It would make sense considering how important this working is. |
|
if you feel confident enough to add one, that would be cool. might require reworking a bit of the code/methods though. but please do it in another PR. this PR must not be delayed, it has to be deployed asap. |
marko-radosavljevic
approved these changes
Oct 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes top helper anticheat not counting visible charachters instead of invisible ones. This was caused by me using a capital
Pfor matching invisible charachters which selects all characters not being invisible. Everything now works as intended.This also includes Zabuzard's suggestion of using a Pattern directly to replace the invisible chars which avoids String#replaceAll compiling a new pattern every time.