Skip to content

Add tests for TopHelperMessageListener #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 5, 2022
Merged

Add tests for TopHelperMessageListener #661

merged 13 commits into from
Nov 5, 2022

Conversation

Nxllpointer
Copy link
Contributor

@Nxllpointer Nxllpointer commented Oct 26, 2022 •
edited
Loading

Adds tests for the TopHelperMessageListener checks and anticheat. This is important because if the Top-Helper system fails, track of the helpers messages is lost.

@Nxllpointer Nxllpointer requested review from a team as code owners October 26, 2022 18:03
@Nxllpointer Nxllpointer self-assigned this Oct 26, 2022
@Nxllpointer Nxllpointer added enhancement New feature or request priority: low labels Oct 26, 2022
Zabuzard
Zabuzard requested changes Oct 27, 2022
View reviewed changes
Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. Just some minor things.

Even better would be to test more of the code though, like a full method.

But thats also better than nothing 👍

@Nxllpointer
Copy link
Contributor Author

Nxllpointer commented Oct 27, 2022 •
edited
Loading

Even better would be to test more of the code though, like a full method.

@Zabuzard you mean sending a fake message and checking the database entry?

@Zabuzard
Copy link
Member

that would be the ultimate test, yes.

but it would also already help if there would be some sort of countMessageLength method and you would test that.

@Nxllpointer Nxllpointer changed the title Add test for top-helper-anticheat Add tests for TopHelperMessageListener Oct 27, 2022
@Nxllpointer
Copy link
Contributor Author

Ok i changed pretty much everything. Tests now also include the checks if a message is supposed count.

Zabuzard
Zabuzard requested changes Oct 28, 2022
View reviewed changes
@Nxllpointer
Copy link
Contributor Author

Ok great. I took a look at the JDATester and implemented support for thread channels. You can now specify your ChannelType in createMessageReceiveEvent

@Nxllpointer Nxllpointer requested a review from Zabuzard October 30, 2022 01:42
Zabuzard
Zabuzard requested changes Nov 2, 2022
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Nxllpointer Nxllpointer dismissed Tais993’s stale review November 5, 2022 12:51

Everything resolved without margin for further questions

@Nxllpointer Nxllpointer merged commit d523945 into develop Nov 5, 2022
@Nxllpointer Nxllpointer deleted the test/top-helper-anticheat-test branch November 5, 2022 12:55
@Zabuzard Zabuzard mentioned this pull request Nov 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zabuzard Zabuzard Zabuzard approved these changes

@Taz03 Taz03 Taz03 approved these changes

@Tais993 Tais993 Awaiting requested review from Tais993

Assignees

@Nxllpointer Nxllpointer

Labels

enhancement New feature or request priority: low

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Nxllpointer @Zabuzard @Tais993 @Taz03