Fix Top-Helper message length exploit

[Nxllpointer]

Fixes #648

One was able to farm Top-Helper message length points by adding invisible characters to help messages

[Zabuzard]

Can you test it quickly? Just to make sure it really works as expected, thanks.

[Nxllpointer]

Can you test it quickly? Just to make sure it really works as expected, thanks.

It works with the zero width joiner. Charachters like äöü for example were also excluded but because the discord is english this should not be an issue

[Zabuzard]

@Nxllpointer why are umlaute excluded with \P{C}? that category should list all invisible characters. the umlaute are visible. are we really sure we just filtered what we expect and didnt kill everything? please doublecheck that regular characters still count.

[java-coding-prodigy]

@Nxllpointer why are umlaute excluded with \P{C}? that category should list all invisible characters. the umlaute are visible. are we really sure we just filtered what we expect and didnt kill everything? please doublecheck that regular characters still count.

You could do \P{C}|<Whatever the regex for umluate is> in that case

[Zabuzard]

im okay with what it is. im just confused why its not included. which yields me to thinking that there might be a bug in your code. let me check it on regex101.com quickly

[Nxllpointer]

Maybe it's an issue with how java handles Unicode categories

[Zabuzard]

Maybe it's an issue with how java handles Unicode categories

Are you sure it messes up umlaute? When I test it locally, it works.

[Zabuzard]

Btw, you should have used a Pattern instead of a raw string for the replacement. Would be faster. But welp, too late.

[Nxllpointer]

Hm. I used a string because replaceAll does not accept a pattern. Is there an easy readable solution?

[Zabuzard]

Hm. I used a string because replaceAll does not accept a pattern. Is there an easy readable solution?

replacement via pattern goes through the pattern, not from string. sth like pattern.replace(...).

anyways, lets concentrate on why u think that the code doesnt work for umlaute. please elaborate

[Nxllpointer]

Maybe I also can't read a number. If it works for you it should also work for the bot

[Nxllpointer]

If you want to I can change it to a pattern later

[Zabuzard]

ur not getting me. u claimed that it doesnt work for umlaute. why did u say that? did u try it out and it didnt work? do we have a bug in the code?

[Nxllpointer]

When I tried it it didn't work. Maybe I just forgot to update the database viewer. You can test if it works.

[Nxllpointer]

@Zabuzard oops I just realized that instead of counting the visible chars I counted the invisible ones... I will make a PR with the fix and using Pattern.

[Nxllpointer]

Weird the Java regex seems to ignore the case of the P
Edit: it works again even though i didnt change anything

[Nxllpointer]

PR should fix everything now. Sorry for this stupid mistake.