Only fill the nonzeros #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Part of the JuliaGPU/CUDA.jl#1367 fixes |
Codecov Report
@@ Coverage Diff @@
## main #104 +/- ##
==========================================
- Coverage 59.23% 58.99% -0.24%
==========================================
Files 10 10
Lines 574 578 +4
==========================================
+ Hits 340 341 +1
- Misses 234 237 +3
Continue to review full report at Codecov.
|
ChrisRackauckas
added a commit
to JuliaArrays/ArrayInterface.jl
that referenced
this pull request
Feb 11, 2022
Looks like this is a missing verb in the sparse matrix vocabulary which is required for writing generic sparse functionality that also works on the GPU. Here's 3 PRs which currently only work on the CPU because of the missing verb: - JuliaDiff/SparseDiffTools.jl#179 - SciML/LinearSolve.jl#104 - JuliaDiff/FiniteDiff.jl#130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JuliaLang/julia#17670