Skip to content

don't fill! on a SparseMatrix #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2022
Merged

don't fill! on a SparseMatrix #179

merged 1 commit into from
Feb 11, 2022

Conversation

ChrisRackauckas
Copy link
Member

julia> x = sprand(2,2,0.5)
2×2 SparseMatrixCSC{Float64, Int64} with 1 stored entry:
 0.507603    
            

julia> fill!(x, true)
2×2 SparseMatrixCSC{Float64, Int64} with 4 stored entries:
 1.0  1.0
 1.0  1.0

Seems like an issue for Base.

```julia
julia> x = sprand(2,2,0.5)
2×2 SparseMatrixCSC{Float64, Int64} with 1 stored entry:
 0.507603   ⋅ 
  ⋅         ⋅ 

julia> fill!(x, true)
2×2 SparseMatrixCSC{Float64, Int64} with 4 stored entries:
 1.0  1.0
 1.0  1.0
```

Seems like an issue for Base.
@ChrisRackauckas
Copy link
Member Author

JuliaLang/julia#17670

@ChrisRackauckas
Copy link
Member Author

Most now supports CUDA JuliaGPU/CUDA.jl#1367

ChrisRackauckas added a commit to JuliaArrays/ArrayInterface.jl that referenced this pull request Feb 11, 2022
Looks like this is a missing verb in the sparse matrix vocabulary which is required for writing generic sparse functionality that also works on the GPU. Here's 3 PRs which currently only work on the CPU because of the missing verb:

- JuliaDiff/SparseDiffTools.jl#179
- SciML/LinearSolve.jl#104
- JuliaDiff/FiniteDiff.jl#130
@ChrisRackauckas ChrisRackauckas merged commit a9547ed into master Feb 11, 2022
@ChrisRackauckas ChrisRackauckas deleted the fill_bang branch February 11, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant