Add issparsematrix #242
Closed
Add issparsematrix #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like this is a missing verb in the sparse matrix vocabulary which is required for writing generic sparse functionality that also works on the GPU. Here's 3 PRs which currently only work on the CPU because of the missing verb: - JuliaDiff/SparseDiffTools.jl#179 - SciML/LinearSolve.jl#104 - JuliaDiff/FiniteDiff.jl#130
|
@Tokazama I want to be able to use this downstream ASAP, so please fix your mess or I will need to revert it. |
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
==========================================
- Coverage 89.45% 89.20% -0.25%
==========================================
Files 11 11
Lines 1754 1760 +6
==========================================
+ Hits 1569 1570 +1
- Misses 185 190 +5
Continue to review full report at Codecov.
|
|
AbstractSparseMatrix seems to work well enough. |
|
But I still don't want master broken downstream for long. That's just a very bad sign. |
|
What mess are you referring to? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this is a missing verb in the sparse matrix vocabulary which is required for writing generic sparse functionality that also works on the GPU. Here's 3 PRs which currently only work on the CPU because of the missing verb: