-
Notifications
You must be signed in to change notification settings - Fork 5.5k
fix(sdk+connect-react): string_options -> stringOptions #14867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
WalkthroughThe changes in this pull request include updates to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (3)
🔇 Additional comments (4)packages/connect-react/package.json (1)
The version bump to 1.0.0-preview.7 is appropriate for the property naming change, and switching to a workspace dependency is a good practice in monorepos. Also applies to: 30-30 packages/connect-react/src/components/RemoteOptionsContainer.tsx (1)
The destructuring of the response has been updated to use packages/sdk/src/shared/index.ts (2)
The property rename from
The explicit return type Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Summary by CodeRabbit
Release Notes
connect-react
andsdk
packages to reflect recent changes and fixes.stringOptions
in various components and SDK responses for consistency.RemoteOptionsContainer
component for better user feedback.