Biz/dj 2789 show prop label instead of the value #15370

bzwrk · 2025-01-22T22:25:03Z

WHY

Summary by CodeRabbit

New Features
- Updated dropdown selection behavior to display prop labels instead of values
- Removed custom string input for remote options
Chores
- Bumped package version to 1.0.0-preview.23
Bug Fixes
- Improved option selection logic in dropdown component

…-value

linear · 2025-01-22T22:25:08Z

DJ-2789 Show prop label instead of the value

vercel · 2025-01-22T22:25:10Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Ignored (Inspect)	Jan 22, 2025 10:25pm
pipedream-docs	⬜️ Ignored (Inspect)	Jan 22, 2025 10:25pm
pipedream-docs-redirect-do-not-edit	⬜️ Ignored (Inspect)	Jan 22, 2025 10:25pm

coderabbitai · 2025-01-22T22:25:13Z

Walkthrough

The pull request introduces changes to the @pipedream/connect-react package, specifically modifying the ControlSelect component's dropdown selection behavior. The version has been updated from 1.0.0-preview.22 to 1.0.0-preview.23. The key modification involves displaying the prop label instead of the value after selecting an option from a dropdown for string array props. The changes enhance the user interface by providing clearer context for selected options and refine the logic for handling option selections.

Changes

File	Change Summary
`packages/connect-react/CHANGELOG.md`	Added entry for version `1.0.0-preview.23` describing dropdown label display change
`packages/connect-react/package.json`	Updated package version from `1.0.0-preview.22` to `1.0.0-preview.23`
`packages/connect-react/src/components/ControlSelect.tsx`	Refined `selectValue` logic for handling option selections, creating an `obj` variable to represent selected options more explicitly

Sequence Diagram

sequenceDiagram
    participant User
    participant ControlSelect
    participant Options
    
    User->>ControlSelect: Select dropdown option
    ControlSelect->>Options: Check selected value
    Options-->>ControlSelect: Match option details
    ControlSelect->>ControlSelect: Create option object
    ControlSelect->>User: Display option label

Possibly related PRs

fix(sdk+connect-react): string_options -> stringOptions #14867: Changes to string_options casing in dropdown handling
fix: Enforce string limits #14953: Enforcing string limits in dropdown properties
Fix a bug with async prop value validation #15334: Bug fix for async prop value validation
Biz/dj 2813 support custom input strings in connect react #15356: Support for custom input strings in dropdowns

Suggested reviewers

jverce

Poem

🥕 A dropdown's tale of labels bright,
Where values hide from user's sight
With preview twenty-three's new grace,
We show the label's friendly face
A rabbit's code, both clear and light! 🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/connect-react/src/components/ControlSelect.tsx (1)
50-60: LGTM! The refactored logic improves label handling.

The changes effectively implement the requirement to show prop labels instead of values for string array props. The new implementation properly initializes the object before searching for matching options, making the code more maintainable.

A minor optimization suggestion: Consider using find instead of a for loop to improve readability.
-            for (const item of options) {
-              if (item.value === o) {
-                obj = item;
-                break;
-              }
-            }
+            const matchingOption = options.find(item => item.value === o);
+            if (matchingOption) {
+              obj = matchingOption;
+            }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 73fdd00 and ee3fcf4.

⛔ Files ignored due to path filters (2)

packages/connect-react/examples/nextjs/package-lock.json is excluded by !**/package-lock.json
pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (3)

packages/connect-react/CHANGELOG.md (1 hunks)
packages/connect-react/package.json (1 hunks)
packages/connect-react/src/components/ControlSelect.tsx (1 hunks)

✅ Files skipped from review due to trivial changes (1)

packages/connect-react/package.json

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: pnpm publish

🔇 Additional comments (1)

packages/connect-react/CHANGELOG.md (1)

4-7: LGTM! Clear and accurate changelog entry.

The changelog entry properly documents the change in behavior for displaying prop labels instead of values in dropdown selections.

bzwrk added 5 commits January 22, 2025 16:09

Show label instead of value on async option selection

90c0157

Merge branch 'master' into biz/dj-2789-show-prop-label-instead-of-the…

07e870b

…-value

Update changelog

3f13fa4

Update changelog

bc8e934

Update changelog

ee3fcf4

coderabbitai bot reviewed Jan 22, 2025

View reviewed changes

jverce approved these changes Jan 23, 2025

View reviewed changes

bzwrk merged commit 1e8ec87 into master Jan 23, 2025
8 checks passed

bzwrk deleted the biz/dj-2789-show-prop-label-instead-of-the-value branch January 23, 2025 00:16

This was referenced Jan 24, 2025

Biz/dj 2825 remote options gets unset when loading configuredprops #15401

Merged

Biz/dj 2837 show label and keep selected remote option dropdown enabled #15438

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Biz/dj 2789 show prop label instead of the value #15370

Biz/dj 2789 show prop label instead of the value #15370

Uh oh!

bzwrk commented Jan 22, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

linear bot commented Jan 22, 2025

Uh oh!

vercel bot commented Jan 22, 2025

Uh oh!

coderabbitai bot commented Jan 22, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Biz/dj 2789 show prop label instead of the value #15370

Biz/dj 2789 show prop label instead of the value #15370

Uh oh!

Conversation

bzwrk commented Jan 22, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

WHY

Summary by CodeRabbit

Uh oh!

linear bot commented Jan 22, 2025

Uh oh!

vercel bot commented Jan 22, 2025

Uh oh!

coderabbitai bot commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram

Possibly related PRs

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bzwrk commented Jan 22, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 22, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)