Skip to content

Commit 44373f7

Browse files
authored
fix(sdk+connect-react): string_options -> stringOptions (#14867)
1 parent 74a3ff3 commit 44373f7

File tree

7 files changed

+19
-15
lines changed

7 files changed

+19
-15
lines changed

packages/connect-react/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
<!-- markdownlint-disable MD024 -->
22
# Changelog
33

4+
# [1.0.0-preview.7] - 2024-12-05
5+
6+
- Use proper casing for `stringOptions` now that configure prop is properly async
7+
48
# [1.0.0-preview.6] - 2024-12-05
59

610
- Handle configurable prop `withLabel` (eg. fixes config of Airtable `tableId`)

packages/connect-react/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@pipedream/connect-react",
3-
"version": "1.0.0-preview.6",
3+
"version": "1.0.0-preview.7",
44
"description": "Pipedream Connect library for React",
55
"files": [
66
"dist"
@@ -27,7 +27,7 @@
2727
"author": "Pipedream Engineering",
2828
"license": "MIT",
2929
"dependencies": {
30-
"@pipedream/sdk": "^1.0.6",
30+
"@pipedream/sdk": "workspace:^",
3131
"@tanstack/react-query": "^5.59.16",
3232
"lodash.isequal": "^4.5.0",
3333
"react-markdown": "^9.0.1",

packages/connect-react/src/components/RemoteOptionsContainer.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ export function RemoteOptionsContainer({ queryEnabled }: RemoteOptionsContainerP
7070
// console.log("res", res)
7171
// XXX look at errors in response here too
7272
const {
73-
options, string_options: stringOptions, errors,
73+
options, stringOptions, errors,
7474
} = res;
7575
if (errors?.length) {
7676
// TODO field context setError? (for validity, etc.)

packages/sdk/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
<!-- markdownlint-disable MD024 -->
22
# Changelog
33

4+
## [1.0.10] - 2024-12-04
5+
6+
### Changed
7+
8+
- Handle correct casing of `stringOptions` in configure prop response
9+
410
## [1.0.9] - 2024-12-04
511

612
### Added

packages/sdk/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@pipedream/sdk",
3-
"version": "1.0.9",
3+
"version": "1.0.10",
44
"description": "Pipedream SDK",
55
"main": "dist/server/server/index.js",
66
"module": "dist/server/server/index.js",

packages/sdk/src/shared/index.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ export type AppResponse = AppInfo & {
9191

9292
export type ComponentConfigureResponse = {
9393
options: { label: string; value: string; }[];
94-
string_options: string[];
94+
stringOptions: string[];
9595
errors: string[];
9696
};
9797

@@ -580,11 +580,7 @@ export abstract class BaseClient {
580580
configured_props: opts.configuredProps,
581581
dynamic_props_id: opts.dynamicPropsId,
582582
};
583-
return await this.makeConnectRequestAsync<{
584-
options: { label: string; value: string; }[];
585-
string_options: string[];
586-
errors: string[];
587-
}>("/components/configure", {
583+
return await this.makeConnectRequestAsync<ComponentConfigureResponse>("/components/configure", {
588584
method: "POST",
589585
body,
590586
});

pnpm-lock.yaml

Lines changed: 3 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)