-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix tests for new tensorboard >= 2.6 #8789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit cc03615.
Codecov Report
@@ Coverage Diff @@
## master #8789 +/- ##
======================================
Coverage 89% 89%
======================================
Files 169 169
Lines 14068 14068
======================================
Hits 12460 12460
Misses 1608 1608 |
This reverts commit 4e53d29.
carmocca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we open a GH issue in https://github.com/tensorflow/tensorboard?
|
Yes although I'm still missing some information. The issue is that on the CPU installation it works fine. There must be another dependency (of tensorboard?) that plays a role here and which is different in the GPU container. |
(cherry picked from commit 346cef2)
(cherry picked from commit 346cef2)
Unblocks master branch for failing tests.
Tensorboard recently released 2.6.0, which breaks one of our tests.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃