-
Notifications
You must be signed in to change notification settings - Fork 3.6k
lift tensorboard version restriction #8765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8765 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 169 169
Lines 14072 14103 +31
======================================
+ Hits 13041 13064 +23
- Misses 1031 1039 +8 |
Borda
approved these changes
Aug 6, 2021
carmocca
approved these changes
Aug 6, 2021
SkafteNicki
approved these changes
Aug 6, 2021
Contributor
|
Seems like this broke master... ______________ ERROR collecting tests/loggers/test_tensorboard.py ______________
tests/loggers/test_tensorboard.py:23: in <module>
from tensorboard.backend.event_processing.event_accumulator import EventAccumulator
/usr/local/lib/python3.7/dist-packages/tensorboard/backend/event_processing/event_accumulator.py:21: in <module>
from tensorboard.backend.event_processing import event_file_loader
/usr/local/lib/python3.7/dist-packages/tensorboard/backend/event_processing/event_file_loader.py:21: in <module>
from tensorboard import dataclass_compat
/usr/local/lib/python3.7/dist-packages/tensorboard/dataclass_compat.py:35: in <module>
from tensorboard.plugins.mesh import metadata as mesh_metadata
/usr/local/lib/python3.7/dist-packages/tensorboard/plugins/mesh/metadata.py:20: in <module>
from tensorboard.plugins.mesh import plugin_data_pb2
/usr/local/lib/python3.7/dist-packages/tensorboard/plugins/mesh/plugin_data_pb2.py:23: in <module>
serialized_pb=_b('\n*tensorboard/plugins/mesh/plugin_data.proto\x12\x10tensorboard.mesh\"\xea\x01\n\x0eMeshPluginData\x12\x0f\n\x07version\x18\x01 \x01(\x05\x12\x0c\n\x04name\x18\x02 \x01(\t\x12\x42\n\x0c\x63ontent_type\x18\x03 \x01(\x0e\x32,.tensorboard.mesh.MeshPluginData.ContentType\x12\x13\n\x0bjson_config\x18\x05 \x01(\t\x12\r\n\x05shape\x18\x06 \x03(\x05\x12\x12\n\ncomponents\x18\x07 \x01(\r\"=\n\x0b\x43ontentType\x12\r\n\tUNDEFINED\x10\x00\x12\n\n\x06VERTEX\x10\x01\x12\x08\n\x04\x46\x41\x43\x45\x10\x02\x12\t\n\x05\x43OLOR\x10\x03\x62\x06proto3')
/usr/local/lib/python3.7/dist-packages/google/protobuf/descriptor.py:983: in __new__
return _message.default_pool.AddSerializedFile(serialized_pb)
E TypeError: Couldn't build proto file into descriptor pool!
E Invalid proto descriptor for file "tensorboard/plugins/mesh/plugin_data.proto":
E tensorboard.mesh.MeshPluginData.version: "tensorboard.mesh.MeshPluginData.version" is already defined in file "tensorboardX/proto/plugin_mesh.proto".
E tensorboard.mesh.MeshPluginData.name: "tensorboard.mesh.MeshPluginData.name" is already defined in file "tensorboardX/proto/plugin_mesh.proto".
E tensorboard.mesh.MeshPluginData.content_type: "tensorboard.mesh.MeshPluginData.content_type" is already defined in file "tensorboardX/proto/plugin_mesh.proto".
E tensorboard.mesh.MeshPluginData.json_config: "tensorboard.mesh.MeshPluginData.json_config" is already defined in file "tensorboardX/proto/plugin_mesh.proto".
E tensorboard.mesh.MeshPluginData.shape: "tensorboard.mesh.MeshPluginData.shape" is already defined in file "tensorboardX/proto/plugin_mesh.proto".
E tensorboard.mesh.MeshPluginData.UNDEFINED: "tensorboard.mesh.MeshPluginData.UNDEFINED" is already defined in file "tensorboardX/proto/plugin_mesh.proto".
E tensorboard.mesh.MeshPluginData.UNDEFINED: Note that enum values use C++ scoping rules, meaning that enum values are siblings of their type, not children of it. Therefore, "UNDEFINED" must be unique within "tensorboard.mesh.MeshPluginData", not just within "ContentType".
E tensorboard.mesh.MeshPluginData.VERTEX: "tensorboard.mesh.MeshPluginData.VERTEX" is already defined in file "tensorboardX/proto/plugin_mesh.proto".
E tensorboard.mesh.MeshPluginData.VERTEX: Note that enum values use C++ scoping rules, meaning that enum values are siblings of their type, not children of it. Therefore, "VERTEX" must be unique within "tensorboard.mesh.MeshPluginData", not just within "ContentType".
E tensorboard.mesh.MeshPluginData.FACE: "tensorboard.mesh.MeshPluginData.FACE" is already defined in file "tensorboardX/proto/plugin_mesh.proto".
E tensorboard.mesh.MeshPluginData.FACE: Note that enum values use C++ scoping rules, meaning that enum values are siblings of their type, not children of it. Therefore, "FACE" must be unique within "tensorboard.mesh.MeshPluginData", not just within "ContentType".
E tensorboard.mesh.MeshPluginData.COLOR: "tensorboard.mesh.MeshPluginData.COLOR" is already defined in file "tensorboardX/proto/plugin_mesh.proto".
E tensorboard.mesh.MeshPluginData.COLOR: Note that enum values use C++ scoping rules, meaning that enum values are siblings of their type, not children of it. Therefore, "COLOR" must be unique within "tensorboard.mesh.MeshPluginData", not just within "ContentType".
E tensorboard.mesh.MeshPluginData.ContentType: "tensorboard.mesh.MeshPluginData.ContentType" is already defined in file "tensorboardX/proto/plugin_mesh.proto".
E tensorboard.mesh.MeshPluginData: "tensorboard.mesh.MeshPluginData" is already defined in file "tensorboardX/proto/plugin_mesh.proto".
E tensorboard.mesh.MeshPluginData.content_type: "tensorboard.mesh.MeshPluginData.ContentType" seems to be defined in "tensorboardX/proto/plugin_mesh.proto", which is not imported by "tensorboard/plugins/mesh/plugin_data.proto". To use it here, please add the necessary import. |
11 tasks
SeanNaren
pushed a commit
that referenced
this pull request
Aug 10, 2021
(cherry picked from commit cc03615)
lexierule
pushed a commit
that referenced
this pull request
Aug 11, 2021
(cherry picked from commit cc03615)
four4fish
pushed a commit
to four4fish/pytorch-lightning
that referenced
this pull request
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #8754
Labelling it as bugfix to unblock user in #8754 with 1.4.2 release.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃