Skip to content

Fix tests for new tensorboard >= 2.6 #8789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 9, 2021
Merged

Fix tests for new tensorboard >= 2.6 #8789

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3a29009
Revert "lift tensorboard version restriction (#8765)"
awaelchli Aug 7, 2021
aa861a5
Merge branch 'master' into revert-8765-ci/lift-tb-restriction
awaelchli Aug 9, 2021
4e53d29
try fix
awaelchli Aug 9, 2021
07f09d8
Revert "try fix"
awaelchli Aug 9, 2021
dceadee
try lower version
awaelchli Aug 9, 2021
8af42e9
try non-sense
awaelchli Aug 9, 2021
684bc5e
fix import problem
awaelchli Aug 9, 2021
51d785c
trigger ci
awaelchli Aug 9, 2021
65abdcc
try 2.5.0
awaelchli Aug 9, 2021
3d06586
update req
awaelchli Aug 9, 2021
16b2d32
update comment
awaelchli Aug 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tests/loggers/test_tensorboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
import logging
import operator
import os
from argparse import Namespace
from unittest import mock
Expand All @@ -20,14 +21,19 @@
import torch
import yaml
from omegaconf import OmegaConf
from tensorboard.backend.event_processing.event_accumulator import EventAccumulator

from pytorch_lightning import Trainer
from pytorch_lightning.loggers import TensorBoardLogger
from pytorch_lightning.utilities.imports import _compare_version
from tests.helpers import BoringModel


@pytest.mark.skipif(
_compare_version("tensorboard", operator.ge, "2.6.0"), reason="cannot import EventAccumulator in >= 2.6.0"
)
def test_tensorboard_hparams_reload(tmpdir):
from tensorboard.backend.event_processing.event_accumulator import EventAccumulator

class CustomModel(BoringModel):
def __init__(self, b1=0.5, b2=0.999):
super().__init__()
Expand Down