-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[IPU] Fix Custom Poptorch options to IPUPlugin #8223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8223 +/- ##
======================================
- Coverage 93% 92% -1%
======================================
Files 212 212
Lines 13703 13712 +9
======================================
- Hits 12743 12678 -65
- Misses 960 1034 +74 |
davors72
reviewed
Jun 30, 2021
awaelchli
approved these changes
Jun 30, 2021
carmocca
reviewed
Jun 30, 2021
ethanwharris
approved these changes
Jun 30, 2021
Co-authored-by: Carlos Mocholí <[email protected]>
carmocca
approved these changes
Jun 30, 2021
11 tasks
Contributor
Author
|
This has been moved to #8241 as the caching in the CI was breaking the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3rd party
Related to a 3rd-party
accelerator: ipu (removed)
Intelligence Processing Unit
bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When passing custom options to the IPU Plugin, I noticed that some of the options were incorrectly set leading to failures + options are not correctly set in poptorch.
This PR fixes this case where a custom IPUPlugin + options are passed in.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃