Skip to content

Conversation

@SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Jun 30, 2021

What does this PR do?

When passing custom options to the IPU Plugin, I noticed that some of the options were incorrectly set leading to failures + options are not correctly set in poptorch.

This PR fixes this case where a custom IPUPlugin + options are passed in.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren added bug Something isn't working 3rd party Related to a 3rd-party labels Jun 30, 2021
@SeanNaren SeanNaren added this to the v1.4 milestone Jun 30, 2021
@SeanNaren SeanNaren self-assigned this Jun 30, 2021
@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #8223 (ff0c8d7) into master (8b0aec8) will decrease coverage by 1%.
The diff coverage is 10%.

@@          Coverage Diff           @@
##           master   #8223   +/-   ##
======================================
- Coverage      93%     92%   -1%     
======================================
  Files         212     212           
  Lines       13703   13712    +9     
======================================
- Hits        12743   12678   -65     
- Misses        960    1034   +74     

@SeanNaren SeanNaren enabled auto-merge (squash) June 30, 2021 11:51
@edenlightning edenlightning modified the milestones: v1.4, v1.3.x Jul 1, 2021
@SeanNaren SeanNaren modified the milestones: v1.3.x, v1.4 Jul 1, 2021
@SeanNaren SeanNaren disabled auto-merge July 1, 2021 21:12
@SeanNaren SeanNaren enabled auto-merge (squash) July 1, 2021 21:20
@awaelchli awaelchli added the accelerator: ipu (removed) Intelligence Processing Unit label Jul 2, 2021
@SeanNaren
Copy link
Contributor Author

This has been moved to #8241 as the caching in the CI was breaking the test.

@SeanNaren SeanNaren closed this Jul 2, 2021
auto-merge was automatically disabled July 2, 2021 10:27

Pull request was closed

@Borda Borda deleted the fix/ipu_custom branch November 4, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3rd party Related to a 3rd-party accelerator: ipu (removed) Intelligence Processing Unit bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants