-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[IPU] Allow poptorch.Options to override Trainer #8233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8233 +/- ##
======================================
- Coverage 93% 92% -1%
======================================
Files 212 213 +1
Lines 13718 13803 +85
======================================
- Hits 12749 12737 -12
- Misses 969 1066 +97 |
davors72
reviewed
Jul 1, 2021
6ed2cbb to
e78c154
Compare
SeanNaren
commented
Jul 2, 2021
SeanNaren
commented
Jul 5, 2021
SeanNaren
commented
Jul 5, 2021
awaelchli
approved these changes
Jul 5, 2021
tchaton
approved these changes
Jul 5, 2021
justusschock
approved these changes
Jul 5, 2021
Co-authored-by: Adrian Wälchli <[email protected]>
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accelerator: ipu (removed)
Intelligence Processing Unit
feature
Is an improvement or enhancement
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow-on from #8223. This will follow along from the conversation I had with @davors72, allowing the poptorch.Options that are passed into the IPUPlugin to be the source of truth, allowing the user to not have to pass any flags directly to the Trainer. I.e:
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃