Skip to content

Conversation

@SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Jul 1, 2021

What does this PR do?

When passing custom options to the IPU Plugin, I noticed that some of the options were incorrectly set leading to failures + options are not correctly set in poptorch.

This PR fixes this case where a custom IPUPlugin + options are passed in.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #8241 (149e3a5) into master (3e6f884) will decrease coverage by 1%.
The diff coverage is 10%.

@@          Coverage Diff           @@
##           master   #8241   +/-   ##
======================================
- Coverage      93%     92%   -1%     
======================================
  Files         212     212           
  Lines       13679   13707   +28     
======================================
- Hits        12720   12673   -47     
- Misses        959    1034   +75     

@SeanNaren SeanNaren marked this pull request as ready for review July 2, 2021 09:03
@SeanNaren SeanNaren changed the title [IPU] Fix Custom Poptorch options to IPUPlugin #8223 [IPU] Fix Custom Poptorch options to IPUPlugin Jul 2, 2021
@SeanNaren SeanNaren enabled auto-merge (squash) July 2, 2021 10:12
@SeanNaren SeanNaren closed this Jul 2, 2021
auto-merge was automatically disabled July 2, 2021 10:26

Pull request was closed

@SeanNaren SeanNaren reopened this Jul 2, 2021
@SeanNaren SeanNaren enabled auto-merge (squash) July 2, 2021 10:27
@SeanNaren SeanNaren self-assigned this Jul 2, 2021
@SeanNaren SeanNaren added ready PRs ready to be merged accelerator: ipu (removed) Intelligence Processing Unit labels Jul 2, 2021
@SeanNaren SeanNaren added this to the v1.4 milestone Jul 2, 2021
@SeanNaren SeanNaren merged commit 07b1ce2 into master Jul 2, 2021
@SeanNaren SeanNaren deleted the fix/ipu_custom_2 branch July 2, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accelerator: ipu (removed) Intelligence Processing Unit ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants