Skip to content

Conversation

@tchaton
Copy link
Contributor

@tchaton tchaton commented Jun 1, 2021

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

What does this PR do?

Fixes #<issue_number>

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton self-assigned this Jun 1, 2021
@tchaton tchaton modified the milestones: v1.4, v1.3.x Jun 1, 2021
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #7786 (68403fa) into release/1.3.x (e0850b3) will decrease coverage by 4%.
The diff coverage is 100%.

❗ Current head 68403fa differs from pull request most recent head f7027c1. Consider uploading reports for the commit f7027c1 to get more accurate results

@@              Coverage Diff               @@
##           release/1.3.x   #7786    +/-   ##
==============================================
- Coverage             92%     87%    -4%     
==============================================
  Files                200     200            
  Lines              13013   13016     +3     
==============================================
- Hits               11955   11374   -581     
- Misses              1058    1642   +584     

@tchaton tchaton closed this Jun 1, 2021
@tchaton tchaton reopened this Jun 1, 2021
@tchaton tchaton marked this pull request as ready for review June 1, 2021 08:36
Copy link
Collaborator

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changelog is wrong

Borda and others added 3 commits June 1, 2021 12:44
* update precommit

* Update .pre-commit-config.yaml

Co-authored-by: Carlos Mocholí <[email protected]>

* Apply suggestions from code review

Co-authored-by: Carlos Mocholí <[email protected]>

Co-authored-by: Carlos Mocholí <[email protected]>
* call time_elapsed

* elapsed formatting

* format

* update test

* changelog
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@tchaton tchaton enabled auto-merge (squash) June 1, 2021 17:21
@kaushikb11 kaushikb11 disabled auto-merge June 1, 2021 18:13
@lexierule lexierule merged commit 61525f6 into release/1.3.x Jun 1, 2021
@lexierule lexierule deleted the v1.3.4 branch June 1, 2021 18:16
@carmocca carmocca mentioned this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants