Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented May 31, 2021

What does this PR do?

update pre-commit settings

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added feature Is an improvement or enhancement ci Continuous Integration labels May 31, 2021
@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #7781 (01ee92c) into master (7e6010f) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #7781   +/-   ##
======================================
- Coverage      92%     92%   -0%     
======================================
  Files         199     199           
  Lines       12986   12987    +1     
======================================
- Hits        11994   11982   -12     
- Misses        992    1005   +13     

@Borda Borda added the ready PRs ready to be merged label May 31, 2021
Co-authored-by: Carlos Mocholí <[email protected]>
@carmocca carmocca enabled auto-merge (squash) May 31, 2021 20:44
@carmocca carmocca self-requested a review May 31, 2021 21:00
@carmocca carmocca disabled auto-merge May 31, 2021 21:00
@carmocca carmocca self-requested a review May 31, 2021 21:02
@carmocca carmocca changed the title update precommit Update pre-commit and add new hooks May 31, 2021
@Borda Borda enabled auto-merge (squash) May 31, 2021 21:24
@Borda Borda merged commit 0b6fd1d into master Jun 1, 2021
@Borda Borda deleted the ci/precommit branch June 1, 2021 05:43
@tchaton tchaton mentioned this pull request Jun 1, 2021
tchaton pushed a commit that referenced this pull request Jun 1, 2021
* update precommit

* Update .pre-commit-config.yaml

Co-authored-by: Carlos Mocholí <[email protected]>

* Apply suggestions from code review

Co-authored-by: Carlos Mocholí <[email protected]>

Co-authored-by: Carlos Mocholí <[email protected]>
Borda added a commit that referenced this pull request Jun 1, 2021
* update precommit

* Update .pre-commit-config.yaml

Co-authored-by: Carlos Mocholí <[email protected]>

* Apply suggestions from code review

Co-authored-by: Carlos Mocholí <[email protected]>

Co-authored-by: Carlos Mocholí <[email protected]>
tchaton pushed a commit that referenced this pull request Jun 1, 2021
* update precommit

* Update .pre-commit-config.yaml

Co-authored-by: Carlos Mocholí <[email protected]>

* Apply suggestions from code review

Co-authored-by: Carlos Mocholí <[email protected]>

Co-authored-by: Carlos Mocholí <[email protected]>
lexierule pushed a commit that referenced this pull request Jun 1, 2021
* update precommit

* Update .pre-commit-config.yaml

Co-authored-by: Carlos Mocholí <[email protected]>

* Apply suggestions from code review

Co-authored-by: Carlos Mocholí <[email protected]>

Co-authored-by: Carlos Mocholí <[email protected]>
@carmocca carmocca added this to the v1.4 milestone Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration feature Is an improvement or enhancement ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants