fix info message when max training time reached #7780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7780 +/- ##
======================================
- Coverage 93% 92% -0%
======================================
Files 199 199
Lines 12985 12986 +1
======================================
- Hits 12018 11981 -37
- Misses 967 1005 +38 |
awaelchli
force-pushed
the
bugfix/timer-elapsed
branch
from
ca5934b to
d5ce796
Compare
awaelchli
changed the title
awaelchli
changed the title
awaelchli
requested review from
Borda,
SeanNaren,
carmocca,
justusschock,
kaushikb11,
tchaton and
williamFalcon
as code owners
kaushikb11
approved these changes
May 31, 2021
justusschock
approved these changes
May 31, 2021
carmocca
approved these changes
May 31, 2021
Borda
reviewed
May 31, 2021
Comment on lines
+113
to
+114
| assert "Time limit reached." in caplog.text | ||
| assert "Signaling Trainer to stop." in caplog.text |
Collaborator
There was a problem hiding this comment.
Suggested change
| assert "Time limit reached." in caplog.text | |
| assert "Signaling Trainer to stop." in caplog.text | |
| assert re.match(r"Time limit reached. Elapsed time is .*\. Signaling Trainer to stop.", caplog.text) |
Contributor
Author
There was a problem hiding this comment.
@Borda it wouldn't work.
Not even
assert re.match(r".*Time limit reached.*", caplog.text)
wants to match.
Collaborator
There was a problem hiding this comment.
import re
m = "Time limit reached. Elapsed time is any text here I want. Signaling Trainer to stop."
assert re.match(r"Time limit reached. Elapsed time is .*\. Signaling Trainer to stop.", m)or what is in the caplog.text?
Closed
tchaton
pushed a commit
that referenced
this pull request
Jun 1, 2021
* call time_elapsed * elapsed formatting * format * update test * changelog
Borda
pushed a commit
that referenced
this pull request
Jun 1, 2021
* call time_elapsed * elapsed formatting * format * update test * changelog
tchaton
pushed a commit
that referenced
this pull request
Jun 1, 2021
* call time_elapsed * elapsed formatting * format * update test * changelog
lexierule
pushed a commit
that referenced
this pull request
Jun 1, 2021
* call time_elapsed * elapsed formatting * format * update test * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #7778
Fixes incorrect formatting of time remaining.
Now shows a message properly formatted:
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃