Skip to content

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Sep 8, 2022

What does this PR do?

Docs: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target
This is so that forks can access the secrets.

I think this needs to be merged to work. This would explain why probot-cc and circleci did not run

@carmocca carmocca added the ci Continuous Integration label Sep 8, 2022
@carmocca carmocca added this to the all:next milestone Sep 8, 2022
@carmocca carmocca self-assigned this Sep 8, 2022
@carmocca carmocca added ci Continuous Integration and removed ci Continuous Integration labels Sep 8, 2022
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #14603 (aac99ee) into master (9537444) will decrease coverage by 25%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #14603     +/-   ##
=========================================
- Coverage      85%      60%    -25%     
=========================================
  Files         358      358             
  Lines       27083    27046     -37     
=========================================
- Hits        23081    16339   -6742     
- Misses       4002    10707   +6705     

@Borda Borda merged commit b0683b4 into master Sep 8, 2022
@Borda Borda deleted the ci/pr-targer branch September 8, 2022 13:29
@mergify mergify bot added the ready PRs ready to be merged label Sep 8, 2022
krshrimali pushed a commit that referenced this pull request Sep 9, 2022
* Use the `pull_request_target` workflow event
* Minor  cleanup
* ready_for_review
@carmocca carmocca modified the milestones: all:next, pl:1.8 Sep 12, 2022
This was referenced Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants