Skip to content

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Sep 9, 2022

What does this PR do?

Follow-up to #14603. This is so the job runs on the HEAD (correct) SHA, not the base. Yet still having permissions to run on forks.

IMPORTANT: the changes here do not run apply in this PR (thanks GitHub 🙃) and need to be merged first. So there might be an issue.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added the ci Continuous Integration label Sep 9, 2022
@carmocca carmocca added this to the all:next milestone Sep 9, 2022
@carmocca carmocca self-assigned this Sep 9, 2022
@carmocca carmocca marked this pull request as ready for review September 12, 2022 13:07
@Borda Borda requested review from kaushikb11 and otaj September 12, 2022 13:25
@Borda Borda enabled auto-merge (squash) September 12, 2022 13:26
@Borda Borda merged commit dfa570e into master Sep 12, 2022
@Borda Borda deleted the ci/circleci-sha branch September 12, 2022 15:25
@mergify mergify bot added the ready PRs ready to be merged label Sep 12, 2022
krshrimali pushed a commit that referenced this pull request Sep 13, 2022
* Run CircleCI with the HEAD sha, not the base
* Different solution
krshrimali pushed a commit that referenced this pull request Sep 13, 2022
* Run CircleCI with the HEAD sha, not the base
* Different solution
krshrimali pushed a commit that referenced this pull request Sep 13, 2022
* Run CircleCI with the HEAD sha, not the base
* Different solution
lexierule pushed a commit that referenced this pull request Sep 13, 2022
* Run CircleCI with the HEAD sha, not the base
* Different solution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration ready PRs ready to be merged

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants