Skip to content

Commit b0683b4

Browse files
authored
Use the pull_request_target workflow event (#14603)
* Use the `pull_request_target` workflow event * Minor cleanup * ready_for_review
1 parent 9537444 commit b0683b4

12 files changed

+17
-15
lines changed

.github/workflows/ci-app-examples.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
name: Test App - examples
22

33
# see: https://help.github.com/en/actions/reference/events-that-trigger-workflows
4-
on: # Trigger the workflow on push or pull request, but only for the master branch
4+
on:
55
push:
66
branches: [master, "release/*"]
77
pull_request:
88
branches: [master, "release/*"]
9+
types: [opened, reopened, ready_for_review, synchronize] # add `ready_for_review` since draft is skipped
910
paths:
1011
- ".github/workflows/ci-app-examples.yml"
1112
- "src/lightning_app/**"

.github/workflows/ci-app-tests.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
name: Test App
22

33
# see: https://help.github.com/en/actions/reference/events-that-trigger-workflows
4-
on: # Trigger the workflow on push or pull request, but only for the master branch
4+
on:
55
push:
66
branches: [master, "release/*"]
77
pull_request:
8+
branches: [master, "release/*"]
89
paths:
910
- ".github/workflows/ci-app-tests.yml"
1011
- "src/lightning_app/**"

.github/workflows/ci-circleci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88
- "src/pytorch_lightning/**"
99
- "tests/tests_pytorch/**"
1010
- "setup.cfg" # includes pytest config
11-
pull_request:
11+
pull_request_target:
1212
branches: [master, "release/*"]
1313
paths:
1414
- ".github/workflows/ci-circleci.yml"

.github/workflows/ci-lite-test-full.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
name: Test Lite full
22

33
# see: https://help.github.com/en/actions/reference/events-that-trigger-workflows
4-
on: # Trigger the workflow on push or pull request, but only for the master branch
4+
on:
55
push:
66
branches: [master, "release/*"]
77
pull_request:
88
branches: [master, "release/*"]
9-
types: [opened, reopened, ready_for_review, synchronize]
9+
types: [opened, reopened, ready_for_review, synchronize] # add `ready_for_review` since draft is skipped
1010
paths:
1111
- "requirements/lite/**"
1212
- "src/lightning_lite/**"

.github/workflows/ci-pkg-install.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: Package
22

33
# see: https://help.github.com/en/actions/reference/events-that-trigger-workflows
4-
on: # Trigger the workflow on push or pull request, but only for the master branch
4+
on:
55
push:
66
branches: [master, "release/*"]
77
pull_request:

.github/workflows/ci-pytorch-test-conda.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: Test PyTorch with Conda
22

33
# see: https://help.github.com/en/actions/reference/events-that-trigger-workflows
4-
on: # Trigger the workflow on push or pull request, but only for the master branch
4+
on:
55
push:
66
branches: [master, "release/*"]
77
pull_request:

.github/workflows/ci-pytorch-test-full.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
name: Test PyTorch full
22

33
# see: https://help.github.com/en/actions/reference/events-that-trigger-workflows
4-
on: # Trigger the workflow on push or pull request, but only for the master branch
4+
on:
55
push:
66
branches: [master, "release/*"]
77
pull_request:
88
branches: [master, "release/*"]
9-
types: [opened, reopened, ready_for_review, synchronize]
9+
types: [opened, reopened, ready_for_review, synchronize] # add `ready_for_review` since draft is skipped
1010

1111
concurrency:
1212
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.head_ref }}

.github/workflows/ci-pytorch-test-slow.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
name: Test PyTorch slow
22

33
# see: https://help.github.com/en/actions/reference/events-that-trigger-workflows
4-
on: # Trigger the workflow on push or pull request, but only for the master branch
4+
on:
55
push:
66
branches: [master, "release/*"]
77
pull_request:
88
branches: [master, "release/*"]
9-
types: [opened, reopened, ready_for_review, synchronize]
9+
types: [opened, reopened, ready_for_review, synchronize] # add `ready_for_review` since draft is skipped
1010
paths:
1111
- "requirements/pytorch/**"
1212
- "src/pytorch_lightning/**"

.github/workflows/code-checks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: Code check
22

3-
on: # Trigger the workflow on push or pull request, but only for the master branch
3+
on:
44
push:
55
branches: [master, "release/*"]
66
pull_request:

.github/workflows/docs-checks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: Check Docs
22
# https://github.com/marketplace/actions/sphinx-build
33

4-
on: # Trigger the workflow on push or pull request, but only for the master branch
4+
on:
55
push:
66
branches: [master, "release/*"]
77
pull_request:

0 commit comments

Comments
 (0)