-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Set path filters in favor of the required-job action #14294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a522477 to
b81cba6
Compare
carmocca
commented
Aug 23, 2022
9895469 to
236e194
Compare
carmocca
commented
Aug 23, 2022
carmocca
commented
Sep 8, 2022
carmocca
commented
Sep 15, 2022
awaelchli
reviewed
Sep 20, 2022
awaelchli
approved these changes
Sep 20, 2022
tchaton
approved these changes
Sep 21, 2022
Contributor
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
rohitgr7
pushed a commit
that referenced
this pull request
Sep 24, 2022
Co-authored-by: Jirka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I added the check-group code into our Probot in https://github.com/carmocca/probot in #14621
Before this is merged, we need to unmark all jobs as required but check-group, WIP, pre-commit, check-schema
Closes #14507
Closes #14565
Does your PR introduce any breaking changes? If yes, please list them.
None
cc @Borda @carmocca @akihironitta