Skip to content

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Aug 18, 2022

What does this PR do?

I added the check-group code into our Probot in https://github.com/carmocca/probot in #14621

Before this is merged, we need to unmark all jobs as required but check-group, WIP, pre-commit, check-schema

Closes #14507
Closes #14565

Does your PR introduce any breaking changes? If yes, please list them.

None

cc @Borda @carmocca @akihironitta

@carmocca carmocca added the ci Continuous Integration label Aug 18, 2022
@carmocca carmocca added this to the all:next milestone Aug 18, 2022
@carmocca carmocca self-assigned this Aug 18, 2022
@carmocca carmocca force-pushed the ci/check-group-action branch 7 times, most recently from a522477 to b81cba6 Compare August 23, 2022 13:51
@carmocca carmocca force-pushed the ci/check-group-action branch from 9895469 to 236e194 Compare August 23, 2022 16:20
@carmocca carmocca changed the title Add a required job checker as an action Add a required job checker as an action (2/2) Aug 23, 2022
@carmocca carmocca changed the base branch from master to ci/check-group-action-1 August 23, 2022 16:38
Base automatically changed from ci/check-group-action-1 to master August 23, 2022 23:07
@carmocca carmocca marked this pull request as ready for review September 9, 2022 14:24
@mergify mergify bot removed the has conflicts label Sep 12, 2022
@carmocca carmocca changed the title Add a required job checker as an action (2/2) Set path filters in favor of the required-job action Sep 15, 2022
@carmocca carmocca modified the milestones: all:next, pl:1.8 Sep 15, 2022
@carmocca carmocca enabled auto-merge (squash) September 20, 2022 15:04
@carmocca carmocca requested a review from awaelchli September 20, 2022 16:45
@carmocca carmocca requested a review from Borda September 20, 2022 22:10
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca carmocca merged commit dbb4482 into master Sep 21, 2022
@carmocca carmocca deleted the ci/check-group-action branch September 21, 2022 14:28
@mergify mergify bot added the ready PRs ready to be merged label Sep 21, 2022
rohitgr7 pushed a commit that referenced this pull request Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration ready PRs ready to be merged

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

CI: explore trigger required checks on special comment

4 participants