Skip to content

Conversation

@akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Sep 6, 2022

What does this PR do?

[hotfix] Fixes #14564.
Partially redo #14170 but for a different reason stated in the above issue.

The impact coverage is only PL, so I'm adding this PR to 1.7.x milestone.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @tchaton @rohitgr7 @carmocca @akihironitta @Borda

@akihironitta akihironitta added the ci Continuous Integration label Sep 6, 2022
@akihironitta akihironitta added this to the pl:1.7.x milestone Sep 6, 2022
@akihironitta akihironitta added the priority: 0 High priority task label Sep 6, 2022
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this will increase the burden of app development until #14294 is finished. Hopefully within this week. This is because these jobs are marked as required so they cannot be skipped with a path filter.

@akihironitta akihironitta enabled auto-merge (squash) September 7, 2022 11:39
@akihironitta akihironitta force-pushed the ci/drop-changed-files-macos branch from 56a4474 to 2f6fab2 Compare September 7, 2022 11:50
@awaelchli
Copy link
Contributor

but this will increase the burden of app development until

Should we maybe merge #14294 and this one together on the same day when both are ready?

@Borda Borda enabled auto-merge (squash) September 9, 2022 19:10
@mergify mergify bot added the ready PRs ready to be merged label Sep 9, 2022
@Borda Borda merged commit 92309c2 into master Sep 12, 2022
@Borda Borda deleted the ci/drop-changed-files-macos branch September 12, 2022 18:13
krshrimali pushed a commit that referenced this pull request Sep 13, 2022
krshrimali pushed a commit that referenced this pull request Sep 13, 2022
krshrimali pushed a commit that referenced this pull request Sep 13, 2022
lexierule pushed a commit that referenced this pull request Sep 13, 2022
krshrimali pushed a commit that referenced this pull request Sep 16, 2022
@Borda Borda modified the milestones: pl:1.7.x, all:next Sep 16, 2022
lexierule pushed a commit that referenced this pull request Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration priority: 0 High priority task ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Testing on macOS is always skipped in CI

4 participants