Update checkgroup config #14587
Merged
Update checkgroup config #14587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
reviewed
Sep 7, 2022
awaelchli
approved these changes
Sep 8, 2022
Contributor
awaelchli
left a comment
awaelchli
left a comment
There was a problem hiding this comment.
I thought we undid checkgroup for a reason?
Contributor
Author
|
It's under development, but the config file can only be read off the default branch (master), so I need this merged to continue. (see top post) |
akihironitta
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #14294
Need to merge this into master to continue the above, as it can only read the config in the default branch (master)
This has no impact on CI atm
Does your PR introduce any breaking changes? If yes, please list them.
None
cc @carmocca @akihironitta @Borda