Revert "Fix mypy typing errors in pytorch_lightning/strategies/single_tpu.py" #13544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyprienRicque
requested review from
Borda,
SeanNaren,
awaelchli,
carmocca,
justusschock,
kaushikb11,
rohitgr7,
tchaton and
williamFalcon
as code owners
Member
|
Probably no need to revert it, as #13534 will be merged to 1.7 only and won't be included in 1.6.X |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #13534
In the previous PR I explained that the condition
is_overridden("on_post_move_to_device", self.lightning_module)can not be True. This is incorrect. I missed the heritage ofLightningModulewithModelHooks.Indeed,
ModelHooksimplementson_post_move_to_device.I am very sorry for this.
I think I did not see it in the unit tests because this function has been deprecated in v1.5 and will be removed in v1.7, therefore it is not tested. According to this test: https://github.com/Lightning-AI/lightning/blob/61c28cb428a13c2aea6d7f3f55e0f00431a4ea4e/tests/tests_pytorch/deprecated_api/test_remove_1-7.py#L64