Fix mypy typing errors in pytorch_lightning/strategies/single_tpu.py #13534
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes mypy typing errors in pytorch_lightning/strategies/single_tpu.py in #13445.
Does your PR introduce any breaking changes? If yes, please list them.
This could be a breaking change in case I missed something/relative to older lightning versions.
in
SingleTPUStrategyclass, in functionsetup(self, trainer: "pl.Trainer"), the call toself.model.on_post_move_to_device()has been removed because the condition to trigger it cannot beTrue.The condition is
is_overridden("on_post_move_to_device", self.lightning_module). To beTrue, among other things, this condition requires the parent class to contain theon_post_move_to_devicemethod. Thison_post_move_to_devicemethod is not present in any of the parent classes listed inis_overridden, therefore the condition cannot beTrue. (parents classes beingLightningModule,LightningDataModuleandCallback).Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃