Skip to content

Simplify fetching's loader types #13111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 20, 2022
Merged

Simplify fetching's loader types #13111

merged 10 commits into from
Jul 20, 2022

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented May 19, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Minor changes

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @justusschock @awaelchli @ninginthecloud @rohitgr7 @otaj

@carmocca carmocca added bug Something isn't working data handling Generic data-related topic labels May 19, 2022
@carmocca carmocca added this to the 1.6.x milestone May 19, 2022
@carmocca carmocca self-assigned this May 19, 2022
carmocca
carmocca commented May 19, 2022
View reviewed changes
@carmocca carmocca mentioned this pull request May 19, 2022
Closed
@carmocca carmocca force-pushed the bugfix/dali-iterator branch from 61e7c06 to 8c03a5a Compare May 19, 2022 19:49
@carmocca carmocca marked this pull request as ready for review May 19, 2022 19:56
@carmocca carmocca marked this pull request as draft May 30, 2022 16:46
@carmocca carmocca changed the title Manually reset sized DALI iterators Simplify fetching's loader types Jul 13, 2022
@carmocca carmocca added code quality and removed bug Something isn't working data handling Generic data-related topic has conflicts labels Jul 13, 2022
@carmocca carmocca marked this pull request as ready for review July 13, 2022 14:54
@carmocca carmocca modified the milestones: pl:1.6.x, pl:1.7 Jul 13, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jul 14, 2022
@carmocca carmocca enabled auto-merge (squash) July 18, 2022 12:00
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 20, 2022
@codecov
Copy link

codecov bot commented Jul 20, 2022 •
edited
Loading

Codecov Report

Merging #13111 (a269ed1) into master (d786985) will decrease coverage by 10%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #13111     +/-   ##
=========================================
- Coverage      86%      76%    -10%     
=========================================
  Files         327      327             
  Lines       25482    25480      -2     
=========================================
- Hits        21887    19437   -2450     
- Misses       3595     6043   +2448

@carmocca carmocca merged commit bbd364a into master Jul 20, 2022
@carmocca carmocca deleted the bugfix/dali-iterator branch July 20, 2022 12:15
justusschock pushed a commit that referenced this pull request Jul 21, 2022
@carmocca @justusschock
Simplify fetching's loader types (#13111)
a49e8c5
justusschock added a commit that referenced this pull request Jul 25, 2022
@justusschock @rohitgr7
@pre-commit-ci @Borda @raoakarsha @dependabot @carmocca @manskx @awaelchli @Jungwon-Lee @NathanielDamours @jxtngx @otaj @gautierdag @akihironitta
Merge different gpu backends with accelerator='gpu' (#13642)
2278719 
* Rename GPUAccelerator to CUDAAccelerator

* Add back GPUAccelerator and deprecate it

* Remove temporary registration

* accelerator connector reroute

* accelerator_connector tests

* update enums

* lite support + tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* typo

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* move "gpu" support up before actual accelerator flag checks

* Stupid arguments

* fix tests

* change exception type

* fix registry test

* pre-commit

* CI: debug HPU flow (#13419)

* Update the hpu-tests.yml to pull docker from vault
* fire & sudo
* habana-gaudi-hpus
* Check the driver status on gaudi server (#13718)

Co-authored-by: arao <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Akarsha Rao <[email protected]>

* Update typing-extensions requirement from <4.2.1,>=4.0.0 to >=4.0.0,<4.3.1 in /requirements (#13529)

Update typing-extensions requirement in /requirements

Updates the requirements on [typing-extensions](https://github.com/python/typing_extensions) to permit the latest version.
- [Release notes](https://github.com/python/typing_extensions/releases)
- [Changelog](https://github.com/python/typing_extensions/blob/main/CHANGELOG.md)
- [Commits](python/typing_extensions@4.0.0...4.3.0)

---
updated-dependencies:
- dependency-name: typing-extensions
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit suggestions (#13540)

updates:
- [github.com/psf/black: 22.3.0 → 22.6.0](psf/black@22.3.0...22.6.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [FIX] Native FSDP precision + tests (#12985)

* Simplify fetching's loader types (#13111)

* Include app templates to the lightning and app packages (#13731)

* Include app templates to the package

Co-authored-by: mansy <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>

* Fix mypy typing errors in pytorch_lightning/callbacks/model_checkpoint.py (#13617)

Co-authored-by: Carlos Mocholí <[email protected]>

* Fix typos initialize in docs (#13557)


Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>

* Fix main progress bar counter when `val_check_interval=int` and `check_val_every_n_epoch=None` (#12832)

* Fix mypy errors attributed to `pytorch_lightning.loggers.tensorboard.py` (#13688)

Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>

* Fix mypy errors attributed to `pytorch_lightning.loggers.mlflow` (#13691)

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: otaj <[email protected]>

* fix mypy errors for loggers/wandb.py (#13483)


Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Akihiro Nitta <[email protected]>

* Fix gatekeeper minimum check (#13769)

* changelog

* changelog

* fix order

* move up again

* add missing test

Co-authored-by: rohitgr7 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: arao <[email protected]>
Co-authored-by: Akarsha Rao <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sean Naren <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Mansy <[email protected]>
Co-authored-by: mansy <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: Lee Jungwon <[email protected]>
Co-authored-by: Nathaniel D'Amours <[email protected]>
Co-authored-by: Justin Goheen <[email protected]>
Co-authored-by: otaj <[email protected]>
Co-authored-by: Gautier Dagan <[email protected]>
Co-authored-by: Akihiro Nitta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

+2 more reviewers

@awaelchli awaelchli awaelchli approved these changes

@otaj otaj otaj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carmocca carmocca

Labels

code quality pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

None yet

Milestone

pl:1.7

Development

Successfully merging this pull request may close these issues.

4 participants

@carmocca @awaelchli @Borda @otaj