Fix mypy typing errors in pytorch_lightning/callbacks/model_checkpoint.py #13617

Jungwon-Lee · 2022-07-12T10:54:09Z

What does this PR do?

Fix typing errors in pytorch_lightning/callbacks/model_checkpoint.py in issue #13445.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

…/lightning into typing_model_checkpoint

for more information, see https://pre-commit.ci

carmocca

LGTM! I pushed some changes fixing some of the types

src/pytorch_lightning/callbacks/model_checkpoint.py

src/pytorch_lightning/strategies/dp.py

src/pytorch_lightning/callbacks/early_stopping.py

src/pytorch_lightning/callbacks/model_checkpoint.py

src/pytorch_lightning/trainer/trainer.py

codecov · 2022-07-20T12:09:02Z

Codecov Report

Merging #13617 (953a087) into master (ca1917e) will increase coverage by 27%.
The diff coverage is 85%.

@@            Coverage Diff            @@
##           master   #13617     +/-   ##
=========================================
+ Coverage      49%      76%    +27%     
=========================================
  Files         327      327             
  Lines       25432    25481     +49     
=========================================
+ Hits        12429    19441   +7012     
+ Misses      13003     6040   -6963

…t.py (#13617) Co-authored-by: Carlos Mocholí <[email protected]>

* Rename GPUAccelerator to CUDAAccelerator * Add back GPUAccelerator and deprecate it * Remove temporary registration * accelerator connector reroute * accelerator_connector tests * update enums * lite support + tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * typo * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * move "gpu" support up before actual accelerator flag checks * Stupid arguments * fix tests * change exception type * fix registry test * pre-commit * CI: debug HPU flow (#13419) * Update the hpu-tests.yml to pull docker from vault * fire & sudo * habana-gaudi-hpus * Check the driver status on gaudi server (#13718) Co-authored-by: arao <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Akarsha Rao <[email protected]> * Update typing-extensions requirement from <4.2.1,>=4.0.0 to >=4.0.0,<4.3.1 in /requirements (#13529) Update typing-extensions requirement in /requirements Updates the requirements on [typing-extensions](https://github.com/python/typing_extensions) to permit the latest version. - [Release notes](https://github.com/python/typing_extensions/releases) - [Changelog](https://github.com/python/typing_extensions/blob/main/CHANGELOG.md) - [Commits](python/typing_extensions@4.0.0...4.3.0) --- updated-dependencies: - dependency-name: typing-extensions dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [pre-commit.ci] pre-commit suggestions (#13540) updates: - [github.com/psf/black: 22.3.0 → 22.6.0](psf/black@22.3.0...22.6.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * [FIX] Native FSDP precision + tests (#12985) * Simplify fetching's loader types (#13111) * Include app templates to the lightning and app packages (#13731) * Include app templates to the package Co-authored-by: mansy <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]> * Fix mypy typing errors in pytorch_lightning/callbacks/model_checkpoint.py (#13617) Co-authored-by: Carlos Mocholí <[email protected]> * Fix typos initialize in docs (#13557) Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]> * Fix main progress bar counter when `val_check_interval=int` and `check_val_every_n_epoch=None` (#12832) * Fix mypy errors attributed to `pytorch_lightning.loggers.tensorboard.py` (#13688) Co-authored-by: Adrian Wälchli <[email protected]> Co-authored-by: Rohit Gupta <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]> * Fix mypy errors attributed to `pytorch_lightning.loggers.mlflow` (#13691) Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: otaj <[email protected]> * fix mypy errors for loggers/wandb.py (#13483) Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Rohit Gupta <[email protected]> Co-authored-by: Akihiro Nitta <[email protected]> * Fix gatekeeper minimum check (#13769) * changelog * changelog * fix order * move up again * add missing test Co-authored-by: rohitgr7 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: arao <[email protected]> Co-authored-by: Akarsha Rao <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sean Naren <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Mansy <[email protected]> Co-authored-by: mansy <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]> Co-authored-by: Lee Jungwon <[email protected]> Co-authored-by: Nathaniel D'Amours <[email protected]> Co-authored-by: Justin Goheen <[email protected]> Co-authored-by: otaj <[email protected]> Co-authored-by: Gautier Dagan <[email protected]> Co-authored-by: Akihiro Nitta <[email protected]>

Jungwon-Lee added 2 commits July 12, 2022 19:31

Remove callbacks.model_checkpoint in pyproject.toml

970e5fa

fix mypy errors in model_checkpoint.py

fd6f244

Jungwon-Lee requested review from Borda, SeanNaren, awaelchli, carmocca, justusschock, kaushikb11, rohitgr7, tchaton and williamFalcon as code owners July 12, 2022 10:54

mergify bot added the has conflicts label Jul 12, 2022

otaj mentioned this pull request Jul 12, 2022

Improve typing coverage (4/n) #13445

Closed

52 tasks

Merge branch 'master' into typing_model_checkpoint

3f9a068

mergify bot removed the has conflicts label Jul 12, 2022

Jungwon-Lee and others added 6 commits July 12, 2022 20:27

fix pep-error line for ckecking Union[int, bool] variable is True

efd5f63

Merge branch 'typing_model_checkpoint' of https://github.com/BongYang…

3bc6308

…/lightning into typing_model_checkpoint

[pre-commit.ci] auto fixes from pre-commit.com hooks

776574f

for more information, see https://pre-commit.ci

Self review

27fdfbd

Self review

0639746

Merge branch 'master' into typing_model_checkpoint

a6cfc2c

carmocca approved these changes Jul 12, 2022

View reviewed changes

carmocca added code quality community This PR is from the community labels Jul 12, 2022

carmocca self-assigned this Jul 12, 2022

carmocca added this to the pl:1.7 milestone Jul 12, 2022

carmocca added 4 commits July 12, 2022 17:43

Support tensors to reduce_bool_decision

673f2f1

Fix dtype

e3da8ae

Standardize tensor annotation

75fbd3d

Keep int dtype

3963931

Merge branch 'master' into typing_model_checkpoint

9ba9c78

mergify bot added the has conflicts label Jul 14, 2022

otaj approved these changes Jul 14, 2022

View reviewed changes

Merge branch 'master' into typing_model_checkpoint

5f3e8e6

mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jul 14, 2022

awaelchli suggested changes Jul 14, 2022

View reviewed changes

src/pytorch_lightning/callbacks/model_checkpoint.py Outdated Show resolved Hide resolved

src/pytorch_lightning/strategies/dp.py Outdated Show resolved Hide resolved

mergify bot removed the ready PRs ready to be merged label Jul 14, 2022

carmocca added 4 commits July 19, 2022 02:33

Merge branch 'master' into typing_model_checkpoint

3cf4302

assert dirpath not None

7c3c8a7

Undo reduce_bool_decision change. Cast to bool

c2311bf

Merge branch 'master' into typing_model_checkpoint

5c0074b

carmocca requested a review from awaelchli July 19, 2022 11:14

Unused import

bf9e4cb

carmocca enabled auto-merge (squash) July 19, 2022 11:50

rohitgr7 reviewed Jul 19, 2022

View reviewed changes

rohitgr7 approved these changes Jul 19, 2022

View reviewed changes

Merge branch 'master' into typing_model_checkpoint

77c46c0

github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 19, 2022

awaelchli approved these changes Jul 19, 2022

View reviewed changes

mergify bot added the ready PRs ready to be merged label Jul 19, 2022

Merge branch 'master' into typing_model_checkpoint

a2bd6a0

otaj and others added 2 commits July 20, 2022 17:45

Merge branch 'master' into typing_model_checkpoint

9e4626a

empty

953a087

carmocca merged commit b40766c into Lightning-AI:master Jul 20, 2022

justusschock pushed a commit that referenced this pull request Jul 21, 2022

Fix mypy typing errors in pytorch_lightning/callbacks/model_checkpoin…

74ab878

…t.py (#13617) Co-authored-by: Carlos Mocholí <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix mypy typing errors in pytorch_lightning/callbacks/model_checkpoint.py #13617

Fix mypy typing errors in pytorch_lightning/callbacks/model_checkpoint.py #13617

Uh oh!

Jungwon-Lee commented Jul 12, 2022 •

edited

Loading

Uh oh!

carmocca left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jul 20, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Fix mypy typing errors in pytorch_lightning/callbacks/model_checkpoint.py #13617

Fix mypy typing errors in pytorch_lightning/callbacks/model_checkpoint.py #13617

Uh oh!

Conversation

Jungwon-Lee commented Jul 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

PR review

Did you have fun?

Uh oh!

carmocca left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jul 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Jungwon-Lee commented Jul 12, 2022 •

edited

Loading

codecov bot commented Jul 20, 2022 •

edited

Loading