Fix mypy errors attributed to `pytorch_lightning.loggers.mlflow` #13691

jxtngx · 2022-07-17T02:13:00Z

What does this PR do?

Fix mypy errors attributed to pytorch_lightning.loggers.mlflow for issue #13445

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

src/pytorch_lightning/loggers/mlflow.py

awaelchli

after adding assertions LGTM

src/pytorch_lightning/loggers/mlflow.py

src/pytorch_lightning/loggers/logger.py

src/pytorch_lightning/loggers/mlflow.py

src/pytorch_lightning/loggers/logger.py

Co-authored-by: Jirka Borovec <[email protected]>

otaj · 2022-07-20T09:05:08Z

@carmocca are you fine with the PR now?

codecov · 2022-07-20T09:30:29Z

Codecov Report

Merging #13691 (0fe85a1) into master (ca1917e) will increase coverage by 27%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #13691     +/-   ##
=========================================
+ Coverage      49%      76%    +27%     
=========================================
  Files         327      327             
  Lines       25432    25480     +48     
=========================================
+ Hits        12429    19437   +7008     
+ Misses      13003     6043   -6960

src/pytorch_lightning/loggers/logger.py

) Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: otaj <[email protected]>

* Rename GPUAccelerator to CUDAAccelerator * Add back GPUAccelerator and deprecate it * Remove temporary registration * accelerator connector reroute * accelerator_connector tests * update enums * lite support + tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * typo * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * move "gpu" support up before actual accelerator flag checks * Stupid arguments * fix tests * change exception type * fix registry test * pre-commit * CI: debug HPU flow (#13419) * Update the hpu-tests.yml to pull docker from vault * fire & sudo * habana-gaudi-hpus * Check the driver status on gaudi server (#13718) Co-authored-by: arao <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Akarsha Rao <[email protected]> * Update typing-extensions requirement from <4.2.1,>=4.0.0 to >=4.0.0,<4.3.1 in /requirements (#13529) Update typing-extensions requirement in /requirements Updates the requirements on [typing-extensions](https://github.com/python/typing_extensions) to permit the latest version. - [Release notes](https://github.com/python/typing_extensions/releases) - [Changelog](https://github.com/python/typing_extensions/blob/main/CHANGELOG.md) - [Commits](python/typing_extensions@4.0.0...4.3.0) --- updated-dependencies: - dependency-name: typing-extensions dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [pre-commit.ci] pre-commit suggestions (#13540) updates: - [github.com/psf/black: 22.3.0 → 22.6.0](psf/black@22.3.0...22.6.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * [FIX] Native FSDP precision + tests (#12985) * Simplify fetching's loader types (#13111) * Include app templates to the lightning and app packages (#13731) * Include app templates to the package Co-authored-by: mansy <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]> * Fix mypy typing errors in pytorch_lightning/callbacks/model_checkpoint.py (#13617) Co-authored-by: Carlos Mocholí <[email protected]> * Fix typos initialize in docs (#13557) Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]> * Fix main progress bar counter when `val_check_interval=int` and `check_val_every_n_epoch=None` (#12832) * Fix mypy errors attributed to `pytorch_lightning.loggers.tensorboard.py` (#13688) Co-authored-by: Adrian Wälchli <[email protected]> Co-authored-by: Rohit Gupta <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]> * Fix mypy errors attributed to `pytorch_lightning.loggers.mlflow` (#13691) Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: otaj <[email protected]> * fix mypy errors for loggers/wandb.py (#13483) Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Rohit Gupta <[email protected]> Co-authored-by: Akihiro Nitta <[email protected]> * Fix gatekeeper minimum check (#13769) * changelog * changelog * fix order * move up again * add missing test Co-authored-by: rohitgr7 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: arao <[email protected]> Co-authored-by: Akarsha Rao <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sean Naren <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Mansy <[email protected]> Co-authored-by: mansy <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]> Co-authored-by: Lee Jungwon <[email protected]> Co-authored-by: Nathaniel D'Amours <[email protected]> Co-authored-by: Justin Goheen <[email protected]> Co-authored-by: otaj <[email protected]> Co-authored-by: Gautier Dagan <[email protected]> Co-authored-by: Akihiro Nitta <[email protected]>

jxtngx added 2 commits July 16, 2022 22:11

update pyproject.toml for ci code-check

b2201cf

update type hints

3fef739

jxtngx marked this pull request as ready for review July 17, 2022 03:09

jxtngx requested review from Borda, SeanNaren, awaelchli, carmocca, justusschock, kaushikb11, rohitgr7, tchaton and williamFalcon as code owners July 17, 2022 03:09

akihironitta added logger: mlflow code quality community This PR is from the community labels Jul 17, 2022

akihironitta added this to the pl:1.7 milestone Jul 17, 2022

otaj mentioned this pull request Jul 18, 2022

Improve typing coverage (4/n) #13445

Closed

52 tasks

otaj reviewed Jul 18, 2022

View reviewed changes

src/pytorch_lightning/loggers/mlflow.py Outdated Show resolved Hide resolved

src/pytorch_lightning/loggers/mlflow.py Outdated Show resolved Hide resolved

awaelchli approved these changes Jul 18, 2022

View reviewed changes

rohitgr7 approved these changes Jul 18, 2022

View reviewed changes

mergify bot added the ready PRs ready to be merged label Jul 18, 2022

carmocca suggested changes Jul 18, 2022

View reviewed changes

src/pytorch_lightning/loggers/mlflow.py Outdated Show resolved Hide resolved

src/pytorch_lightning/loggers/mlflow.py Outdated Show resolved Hide resolved

mergify bot removed the ready PRs ready to be merged label Jul 18, 2022

update

5952527

jxtngx commented Jul 18, 2022

View reviewed changes

src/pytorch_lightning/loggers/logger.py Show resolved Hide resolved

jxtngx commented Jul 18, 2022

View reviewed changes

src/pytorch_lightning/loggers/logger.py Outdated Show resolved Hide resolved

jxtngx commented Jul 18, 2022

View reviewed changes

src/pytorch_lightning/loggers/mlflow.py Show resolved Hide resolved

jxtngx commented Jul 18, 2022

View reviewed changes

src/pytorch_lightning/loggers/mlflow.py Show resolved Hide resolved

revert save_dir change

3964e93

carmocca requested a review from awaelchli July 18, 2022 20:01

Borda reviewed Jul 18, 2022

View reviewed changes

src/pytorch_lightning/loggers/logger.py Outdated Show resolved Hide resolved

Update src/pytorch_lightning/loggers/logger.py

acbfad3

Co-authored-by: Jirka Borovec <[email protected]>

carmocca assigned otaj Jul 19, 2022

otaj approved these changes Jul 20, 2022

View reviewed changes

Merge branch 'master' into codeq/mlflow-logger

03d7e7f

github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 20, 2022

otaj enabled auto-merge (squash) July 20, 2022 09:06

carmocca approved these changes Jul 20, 2022

View reviewed changes

src/pytorch_lightning/loggers/logger.py Outdated Show resolved Hide resolved

Update src/pytorch_lightning/loggers/logger.py

08415ee

mergify bot added the ready PRs ready to be merged label Jul 20, 2022

awaelchli and others added 2 commits July 20, 2022 16:34

Merge branch 'master' into codeq/mlflow-logger

c4784a3

empty

0fe85a1

otaj merged commit e3b29cb into Lightning-AI:master Jul 21, 2022

justusschock pushed a commit that referenced this pull request Jul 21, 2022

Fix mypy errors attributed to pytorch_lightning.loggers.mlflow (#13691

e36fd77

) Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: otaj <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix mypy errors attributed to `pytorch_lightning.loggers.mlflow` #13691

Fix mypy errors attributed to `pytorch_lightning.loggers.mlflow` #13691

Uh oh!

jxtngx commented Jul 17, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

awaelchli left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

otaj commented Jul 20, 2022

Uh oh!

codecov bot commented Jul 20, 2022 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Fix mypy errors attributed to pytorch_lightning.loggers.mlflow #13691

Fix mypy errors attributed to pytorch_lightning.loggers.mlflow #13691

Uh oh!

Conversation

jxtngx commented Jul 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

PR review

Uh oh!

Uh oh!

Uh oh!

awaelchli left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

otaj commented Jul 20, 2022

Uh oh!

codecov bot commented Jul 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Fix mypy errors attributed to `pytorch_lightning.loggers.mlflow` #13691

Fix mypy errors attributed to `pytorch_lightning.loggers.mlflow` #13691

jxtngx commented Jul 17, 2022 •

edited

Loading

codecov bot commented Jul 20, 2022 •

edited

Loading