Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Dec 22, 2021

What does this PR do?

Part of #10549

After #11226, we need to update the remaining import statements before we add the deprecation path in #11227 (we want to avoid importing the deprecated names internally) .

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @Borda @justusschock @awaelchli @akihironitta

@awaelchli awaelchli added this to the 1.6 milestone Dec 22, 2021
@mergify mergify bot added the ready PRs ready to be merged label Dec 22, 2021
@carmocca carmocca enabled auto-merge (squash) December 23, 2021 02:16
@carmocca carmocca merged commit c210e33 into master Dec 23, 2021
@carmocca carmocca deleted the refactor/strategy-imports branch December 23, 2021 07:26
@kaushikb11 kaushikb11 mentioned this pull request Dec 23, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged refactor strategy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants