Skip to content

Conversation

@kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Dec 23, 2021

What does this PR do?

Missed few statements in #11231. Part of #10549

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @akihironitta

@mergify mergify bot added the ready PRs ready to be merged label Dec 23, 2021
@four4fish
Copy link
Contributor

My guess is old plugin import trainer, trainer import strategy, strategy import old plugin where caused circle import, will #11227 cover the changes in this PR?

@mergify mergify bot added the has conflicts label Jan 3, 2022
@mergify mergify bot removed the has conflicts label Jan 3, 2022
@awaelchli awaelchli enabled auto-merge (squash) January 3, 2022 13:20
@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #11238 (1a80ab0) into master (17cb3c7) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #11238    +/-   ##
========================================
- Coverage      92%      88%    -4%     
========================================
  Files         194      194            
  Lines       16948    16948            
========================================
- Hits        15578    14946   -632     
- Misses       1370     2002   +632     

@awaelchli awaelchli merged commit 5a4df4e into master Jan 3, 2022
@awaelchli awaelchli deleted the update/strategy_import branch January 3, 2022 15:54
rohitgr7 pushed a commit that referenced this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged strategy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants