-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Closed
Labels
needs triageWaiting to be triaged by maintainersWaiting to be triaged by maintainers
Description
What does this PR do?
Part of #12521
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
- Was this discussed/approved via a GitHub issue? (not for typos and docs)
- Did you read the contributor guideline, Pull Request section?
- Did you make sure your PR does only one thing, instead of bundling different changes together?
- Did you make sure to update the documentation with your changes? (if necessary)
- Did you write any new necessary tests? (not for typos and docs)
- Did you verify new and existing tests pass locally with your changes?
- Did you list all the breaking changes introduced by this pull request?
- Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
- Is this pull request ready for review? (if not, please submit in draft mode)
- Check that all items from Before submitting are resolved
- Make sure the title is self-explanatory and the description concisely explains the PR
- Add labels and milestones (and optionally projects) to the PR so it can be classified
Did you have fun?
Yes!
Make sure you had fun coding 🙃
Metadata
Metadata
Assignees
Labels
needs triageWaiting to be triaged by maintainersWaiting to be triaged by maintainers