Skip to content

Conversation

@stanbiryukov
Copy link
Contributor

@stanbiryukov stanbiryukov commented Apr 22, 2022

What does this PR do?

Fixes #12858, which is subset of #12521

Does your PR introduce any breaking changes? If yes, please list them.

Removes from pytorch_lightning.loggers import TestTubeLogger

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Yes!
Make sure you had fun coding 🙃

Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stanbiryukov Thank you for your work! The CI jobs are failing due to the import statement here. Would you mind removing this import statement, too?

  File "/home/runner/work/pytorch-lightning/pytorch-lightning/pytorch_lightning/loggers/__init__.py", line 28, in <module>
    from pytorch_lightning.loggers.test_tube import _TESTTUBE_AVAILABLE, TestTubeLogger  # noqa: F401
ModuleNotFoundError: No module named 'pytorch_lightning.loggers.test_tube'

@stanbiryukov
Copy link
Contributor Author

Hi @stanbiryukov Thank you for your work! The CI jobs are failing due to the import statement here. Would you mind removing this import statement, too?

  File "/home/runner/work/pytorch-lightning/pytorch-lightning/pytorch_lightning/loggers/__init__.py", line 28, in <module>
    from pytorch_lightning.loggers.test_tube import _TESTTUBE_AVAILABLE, TestTubeLogger  # noqa: F401
ModuleNotFoundError: No module named 'pytorch_lightning.loggers.test_tube'

Thanks, @akihironitta. Good point on the __init__.py file. I also updated tests/loggers/test_all.py so those now pass without test_tube.

Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once an entry is added to the changelog, LGTM!

@stanbiryukov
Copy link
Contributor Author

Once an entry is added to the changelog, LGTM!

Thanks @akihironitta - added the removal entry to CHANGELOG.md

@akihironitta akihironitta changed the title remove deprecated test_tube logger Remove deprecated TestTubeLogger Apr 23, 2022
@mergify mergify bot added the ready PRs ready to be merged label Apr 23, 2022
@akihironitta akihironitta enabled auto-merge (squash) April 23, 2022 20:05
@akihironitta akihironitta merged commit 8034919 into Lightning-AI:master Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Includes a breaking change logger: testtube (removed) ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated TestTubeLogger

4 participants