improve type stability of structural zero error for triangular #1413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fails everywhere in a couple of tests. |
jishnub
approved these changes
Aug 13, 2025
jishnub
reviewed
Aug 13, 2025
Co-authored-by: Jishnu Bhattacharya <[email protected]>
|
The one single failing test is a very new one (unrelated to this change), which we may need to make more robust. |
dkarrasch
pushed a commit
that referenced
this pull request
Aug 13, 2025
Co-authored-by: Viral B. Shah <[email protected]> Co-authored-by: Jishnu Bhattacharya <[email protected]>
Merged
ViralBShah
added a commit
that referenced
this pull request
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a trimming error I encountered.