Skip to content

improve type stability of structural zero error for triangular #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2025
Merged

improve type stability of structural zero error for triangular #1413

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a9dc5e
improve type stability of structural zero error for triangular
JeffBezanson Aug 12, 2025
3924f33
Update src/triangular.jl
ViralBShah Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/triangular.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,16 +256,15 @@ Base.@constprop :aggressive @propagate_inbounds function getindex(A::Union{Lower
_shouldforwardindex(A, b) ? A.data[b] : diagzero(A.data, b)
end

_zero_triangular_half_str(::Type{<:UpperOrUnitUpperTriangular}) = "lower"
_zero_triangular_half_str(::Type{<:LowerOrUnitLowerTriangular}) = "upper"
_zero_triangular_half_str(T::Type) = T <: UpperOrUnitUpperTriangular ? "lower" : "upper"

@noinline function throw_nonzeroerror(T, @nospecialize(x), i, j)
@noinline function throw_nonzeroerror(T::DataType, @nospecialize(x), i, j)
Ts = _zero_triangular_half_str(T)
Tn = nameof(T)
throw(ArgumentError(
lazy"cannot set index in the $Ts triangular part ($i, $j) of an $Tn matrix to a nonzero value ($x)"))
end
@noinline function throw_nononeerror(T, @nospecialize(x), i, j)
@noinline function throw_nononeerror(T::DataType, @nospecialize(x), i, j)
Tn = nameof(T)
throw(ArgumentError(
lazy"cannot set index on the diagonal ($i, $j) of an $Tn matrix to a non-unit value ($x)"))
Expand Down Expand Up @@ -311,7 +310,7 @@ end
return A
end

@noinline function throw_setindex_structuralzero_error(T, @nospecialize(x))
@noinline function throw_setindex_structuralzero_error(T::DataType, @nospecialize(x))
Ts = _zero_triangular_half_str(T)
Tn = nameof(T)
throw(ArgumentError(
Expand Down