Skip to content

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Jun 2, 2025

After this,

julia> B = reshape([1:9;], 3, 3)
3×3 Matrix{Int64}:
 1  4  7
 2  5  8
 3  6  9

julia> diagview(B', 1)
2-element view(::Vector{Int64}, 2:4:6) with eltype Int64:
 2
 6

The view directly indexes into the parent, and the adjoint layer is removed. This also makes the view linearly indexed.

@codecov
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.81%. Comparing base (c64c328) to head (1ab987c).
⚠️ Report is 26 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1373   +/-   ##
=======================================
  Coverage   93.81%   93.81%           
=======================================
  Files          34       34           
  Lines       15717    15719    +2     
=======================================
+ Hits        14745    14747    +2     
  Misses        972      972           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub jishnub merged commit 06a5cd1 into master Jun 16, 2025
4 checks passed
@jishnub jishnub deleted the jishnub/diagview_adjtrans branch June 16, 2025 06:57
@ViralBShah ViralBShah added the backport 1.12 Change should be backported to release-1.12 label Aug 13, 2025
dkarrasch pushed a commit that referenced this pull request Aug 18, 2025
After this,
```julia
julia> B = reshape([1:9;], 3, 3)
3×3 Matrix{Int64}:
 1  4  7
 2  5  8
 3  6  9

julia> diagview(B', 1)
2-element view(::Vector{Int64}, 2:4:6) with eltype Int64:
 2
 6
```
The view directly indexes into the parent, and the `adjoint` layer is
removed. This also makes the view linearly indexed.
ViralBShah added a commit that referenced this pull request Aug 19, 2025
@dkarrasch dkarrasch removed the backport 1.12 Change should be backported to release-1.12 label Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants