Skip to content

Conversation

@jaksart1
Copy link
Contributor

PR summary

Added support for specific secret data types while updating and creating secrets, that are specific to each indivicual secret format.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

reggeenr and others added 30 commits August 4, 2022 01:52
fix(build): enabled semantic release
fix(tests): adjusted integration tests
* fix(tests): enabled the v2 integration test suite

* fix(tests): adjusted the integration tests

* fix(tests): adjusted the unit test targeit for travis checks

* adjusted the integration run script

* ignore generated int tests

* adjusted public travis config
BREAKING CHANGE: bump to v2.0.0
semantic-release-bot and others added 13 commits January 24, 2023 08:47
#14)

* feat(secretData): added more strict typing for secret types during create, to align with latest openAPI doc changes.

BREAKING CHANGE: Secret Create params now require specific SecretData type istead of JsonObject, depending on secret type

* added int tests

* test change

* case change update

* updated latest codegen, removed prototype naming convention from secretData so it can be used in update operation
# [3.0.0](https://github.ibm.com/coligo/node-sdk/compare/v2.0.1...v3.0.0) (2023-03-23)

### Features

* **secretData:** added more strict typing for secret types during cr… ([#14](https://github.ibm.com/coligo/node-sdk/issues/14)) ([42f33df](https://github.ibm.com/coligo/node-sdk/commit/42f33df43dd7f444b4f0da284a0ec819881f769e))

### BREAKING CHANGES

* **secretData:** Secret Create params now require specific SecretData type istead of JsonObject, depending on secret type

* added int tests

* test change

* case change update

* updated latest codegen, removed prototype naming convention from secretData so it can be used in update operation
* fix(generator): SDK update 20230324-173329

* fix(deps): currency update

* fix(api): added integration test for egress ips
Signed-off-by: John Sartore <[email protected]>
@jaksart1 jaksart1 requested a review from reggeenr March 27, 2023 16:17
Copy link
Collaborator

@reggeenr reggeenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaksart1 jaksart1 merged commit 0295840 into main Mar 27, 2023
@jaksart1 jaksart1 deleted the sdk-update-20230327-121100 branch March 27, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants