-
Notifications
You must be signed in to change notification settings - Fork 3
Sdk update 20230327 121100 #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currency update
fix(build): enabled semantic release
fix(build): adjusted repo url
# 1.0.0 (2023-01-16) ### Bug Fixes * **build:** adjusted npm registry to pull from ([6dd4815](https://github.ibm.com/coligo/node-sdk/commit/6dd481503e0825c448e2d4bb093ace6f04e9b5c0)) * **build:** adjusted repo url ([7706440](https://github.ibm.com/coligo/node-sdk/commit/7706440d1ce9814a39e3307e764ff64a2950bb0e)) * **build:** enabled semantic release ([81ca8f9](https://github.ibm.com/coligo/node-sdk/commit/81ca8f981203458904904054c77a39329e7cfeac)) * **build:** updated dependencies ([c955c76](https://github.ibm.com/coligo/node-sdk/commit/c955c7605eb9354b2e7cb14b07649e72d4cf1e92)) * improving description of node formatting script and fixing a minor typo ([867cc32](https://github.ibm.com/coligo/node-sdk/commit/867cc3292d12d016067c8cbdf347ae143c04c378)) * improving formatting on the command suggested to fix unit test formatting errors ([b59c126](https://github.ibm.com/coligo/node-sdk/commit/b59c1265e09d15bdfcbccbdd90551248a19bb59e)) * resolve linter and build errors ([4938b18](https://github.ibm.com/coligo/node-sdk/commit/4938b1822f777febc2e6c2f7ca6ec5356c3ef581)) ### Features * add ibm-cloud-code-engine service ([5499c1e](https://github.ibm.com/coligo/node-sdk/commit/5499c1e328002520d3bb83c6a2e59003b8dddd1c)) * **v2:** updated project setup and applied latest api changes ([6693cb6](https://github.ibm.com/coligo/node-sdk/commit/6693cb6abec26de6facfc55ce1d62af9ef348c42))
## [1.0.1](https://github.ibm.com/coligo/node-sdk/compare/v1.0.0...v1.0.1) (2023-01-16) ### Bug Fixes * **build:** adjusted semantic-release config ([ff8f4d5](https://github.ibm.com/coligo/node-sdk/commit/ff8f4d5f5306a0ebc54bf7402de934725547e621))
Enable integration tests
fix(tests): adjusted integration tests
## [1.99.1](https://github.ibm.com/coligo/node-sdk/compare/v1.99.0...v1.99.1) (2023-01-16) ### Bug Fixes * **build:** adjusted travis config ([9d1381c](https://github.ibm.com/coligo/node-sdk/commit/9d1381cd007fc11dce2589cb62ccccbd17f974db)) * **tests:** adjusted integration tests ([12e77cf](https://github.ibm.com/coligo/node-sdk/commit/12e77cfc42dfa3e28a794efa505288d9ba1a6c82)) * **tests:** enabled integration tests ([c709c5f](https://github.ibm.com/coligo/node-sdk/commit/c709c5f7fb9bf3d67ec5cf7a80f446cd7596c430))
* fix(tests): enabled the v2 integration test suite * fix(tests): adjusted the integration tests * fix(tests): adjusted the unit test targeit for travis checks * adjusted the integration run script * ignore generated int tests * adjusted public travis config
## [1.99.2](https://github.ibm.com/coligo/node-sdk/compare/v1.99.1...v1.99.2) (2023-01-24) ### Bug Fixes * **tests:** enabled the v2 integration test suite ([#11](https://github.ibm.com/coligo/node-sdk/issues/11)) ([849b90c](https://github.ibm.com/coligo/node-sdk/commit/849b90c5a2334cc8dfa99885e460a18a134f59b3))
BREAKING CHANGE: bump to v2.0.0
# [2.0.0](https://github.ibm.com/coligo/node-sdk/compare/v1.99.2...v2.0.0) (2023-01-24) ### Features * **core:** release 2. ([#12](https://github.ibm.com/coligo/node-sdk/issues/12)) ([7d7412b](https://github.ibm.com/coligo/node-sdk/commit/7d7412b433fbc71c43333a998cd87460b6965b08)) ### BREAKING CHANGES * **core:** bump to v2.0.0
## [2.0.1](https://github.ibm.com/coligo/node-sdk/compare/v2.0.0...v2.0.1) (2023-01-25) ### Bug Fixes * **docs:** fixed broken links in the readme ([#13](https://github.ibm.com/coligo/node-sdk/issues/13)) ([2f7d449](https://github.ibm.com/coligo/node-sdk/commit/2f7d4491e7cad12fdaf29f7d62dd290303ae0f54))
#14) * feat(secretData): added more strict typing for secret types during create, to align with latest openAPI doc changes. BREAKING CHANGE: Secret Create params now require specific SecretData type istead of JsonObject, depending on secret type * added int tests * test change * case change update * updated latest codegen, removed prototype naming convention from secretData so it can be used in update operation
# [3.0.0](https://github.ibm.com/coligo/node-sdk/compare/v2.0.1...v3.0.0) (2023-03-23) ### Features * **secretData:** added more strict typing for secret types during cr… ([#14](https://github.ibm.com/coligo/node-sdk/issues/14)) ([42f33df](https://github.ibm.com/coligo/node-sdk/commit/42f33df43dd7f444b4f0da284a0ec819881f769e)) ### BREAKING CHANGES * **secretData:** Secret Create params now require specific SecretData type istead of JsonObject, depending on secret type * added int tests * test change * case change update * updated latest codegen, removed prototype naming convention from secretData so it can be used in update operation
* fix(generator): SDK update 20230324-173329 * fix(deps): currency update * fix(api): added integration test for egress ips
# [3.1.0](https://github.ibm.com/coligo/node-sdk/compare/v3.0.0...v3.1.0) (2023-03-24) ### Features * **api:** added support to retrieve egress ips ([dd3851b](https://github.ibm.com/coligo/node-sdk/commit/dd3851b28566063228e5d89f4a18f1f6eea65474))
Signed-off-by: John Sartore <[email protected]>
reggeenr
approved these changes
Mar 27, 2023
Collaborator
reggeenr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Added support for specific secret data types while updating and creating secrets, that are specific to each indivicual secret format.
PR Checklist
Please make sure that your PR fulfills the following requirements:
PR Type
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change?
Other information