-
Notifications
You must be signed in to change notification settings - Fork 3
Sdk update 20230724 094245 #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(test): tls test adjusted * fix(test): added newlines to test * fix(test): prettier
## [3.1.1](https://github.ibm.com/coligo/node-sdk/compare/v3.1.0...v3.1.1) (2023-07-14) ### Bug Fixes * **test:** tls test adjusted ([#23](https://github.ibm.com/coligo/node-sdk/issues/23)) ([1d15dca](https://github.ibm.com/coligo/node-sdk/commit/1d15dca72623780aaf653577570815628d5030d8))
* feat(api): SDK update 20230718-150834 * fix(test): added binding tests * fix(test): modified tests * fix(test): prettier * fix(test): fix test * fix(test): fix test
…(#27) BREAKING CHANGE: Removed SoureURL from required fields for build create operations
# [4.0.0](https://github.ibm.com/coligo/node-sdk/compare/v3.1.1...v4.0.0) (2023-07-21) ### Features * **v4:** Added additional int test, commit msg for semantic release ([#27](https://github.ibm.com/coligo/node-sdk/issues/27)) ([79a0f11](https://github.ibm.com/coligo/node-sdk/commit/79a0f11bbafc92090ba78e3e0ec35961701f5215)) ### BREAKING CHANGES * **v4:** Removed SoureURL from required fields for build create operations
Signed-off-by: John Sartore <[email protected]>
jasonpet
approved these changes
Jul 24, 2023
Contributor
jasonpet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cgarrett-edwards
approved these changes
Jul 24, 2023
michael-magrian
approved these changes
Jul 24, 2023
Member
michael-magrian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jeremy-Johnson-IBM
pushed a commit
that referenced
this pull request
Sep 24, 2025
#14) * feat(secretData): added more strict typing for secret types during create, to align with latest openAPI doc changes. BREAKING CHANGE: Secret Create params now require specific SecretData type istead of JsonObject, depending on secret type * added int tests * test change * case change update * updated latest codegen, removed prototype naming convention from secretData so it can be used in update operation
Jeremy-Johnson-IBM
pushed a commit
that referenced
this pull request
Sep 24, 2025
# [3.0.0](https://github.ibm.com/coligo/node-sdk/compare/v2.0.1...v3.0.0) (2023-03-23) ### Features * **secretData:** added more strict typing for secret types during cr… ([#14](https://github.ibm.com/coligo/node-sdk/issues/14)) ([42f33df](https://github.ibm.com/coligo/node-sdk/commit/42f33df43dd7f444b4f0da284a0ec819881f769e)) ### BREAKING CHANGES * **secretData:** Secret Create params now require specific SecretData type istead of JsonObject, depending on secret type * added int tests * test change * case change update * updated latest codegen, removed prototype naming convention from secretData so it can be used in update operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Added Binding and Project operator secret support
PR Checklist
Please make sure that your PR fulfills the following requirements:
PR Type
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change?
Other information