Skip to content

Conversation

@jaksart1
Copy link
Contributor

PR summary

Added Binding and Project operator secret support

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

reggeenr and others added 10 commits May 23, 2023 21:05
* fix(test): tls test adjusted

* fix(test): added newlines to test

* fix(test): prettier
* feat(api): SDK update 20230718-150834

* fix(test): added binding tests

* fix(test): modified tests

* fix(test): prettier

* fix(test): fix test

* fix(test): fix test
…(#27)

BREAKING CHANGE: Removed SoureURL from required fields for build create operations
# [4.0.0](https://github.ibm.com/coligo/node-sdk/compare/v3.1.1...v4.0.0) (2023-07-21)

### Features

* **v4:** Added additional int test, commit msg for semantic release ([#27](https://github.ibm.com/coligo/node-sdk/issues/27)) ([79a0f11](https://github.ibm.com/coligo/node-sdk/commit/79a0f11bbafc92090ba78e3e0ec35961701f5215))

### BREAKING CHANGES

* **v4:** Removed SoureURL from required fields for build create operations
Signed-off-by: John Sartore <[email protected]>
Copy link
Contributor

@jasonpet jasonpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@michael-magrian michael-magrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaksart1 jaksart1 merged commit 8edfac2 into main Jul 25, 2023
@jaksart1 jaksart1 deleted the sdk-update-20230724-094245 branch July 25, 2023 15:28
Jeremy-Johnson-IBM pushed a commit that referenced this pull request Sep 24, 2025
#14)

* feat(secretData): added more strict typing for secret types during create, to align with latest openAPI doc changes.

BREAKING CHANGE: Secret Create params now require specific SecretData type istead of JsonObject, depending on secret type

* added int tests

* test change

* case change update

* updated latest codegen, removed prototype naming convention from secretData so it can be used in update operation
Jeremy-Johnson-IBM pushed a commit that referenced this pull request Sep 24, 2025
# [3.0.0](https://github.ibm.com/coligo/node-sdk/compare/v2.0.1...v3.0.0) (2023-03-23)

### Features

* **secretData:** added more strict typing for secret types during cr… ([#14](https://github.ibm.com/coligo/node-sdk/issues/14)) ([42f33df](https://github.ibm.com/coligo/node-sdk/commit/42f33df43dd7f444b4f0da284a0ec819881f769e))

### BREAKING CHANGES

* **secretData:** Secret Create params now require specific SecretData type istead of JsonObject, depending on secret type

* added int tests

* test change

* case change update

* updated latest codegen, removed prototype naming convention from secretData so it can be used in update operation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants