Skip to content

Update example.js to be more resilient wrt config response #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2022
Merged

Update example.js to be more resilient wrt config response #10

merged 1 commit into from
Jun 24, 2022

Conversation

@ASEIDEL77
Copy link
Collaborator

@ASEIDEL77 ASEIDEL77 commented Jun 24, 2022

PR summary

Allow the example code to handle parsed and non-parsed responses to be more resilient against HTTP client behavioral changes.

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (minor update to example.js)

Does this PR introduce a breaking change?

  • Yes
  • No

reggeenr
reggeenr approved these changes Jun 24, 2022
View reviewed changes
Copy link
Collaborator

@reggeenr reggeenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reggeenr reggeenr merged commit c4c6f4b into IBM:main Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reggeenr reggeenr reggeenr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ASEIDEL77 @reggeenr