Fix test overwriting a test configuration file #648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattToast
added
area: test
MattToast
force-pushed
the
dont-overwrite-test-conf-files
branch
from
8744053 to
a03f609
Compare
juliaputko
approved these changes
Jul 31, 2024
Contributor
juliaputko
left a comment
juliaputko
left a comment
There was a problem hiding this comment.
looks good to me. Thanks for these changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
pytest tests/test_file_operations.pywas overwriting a test configuration file. This PR fixes the offending test and adds a missingassertstatement.