Skip to content

Fix test overwriting a test configuration file #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Fix test overwriting a test configuration file #648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions tests/test_file_operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,11 +545,12 @@ def test_configure_op(test_dir, fileutils, param_dict, error_type):
assert filecmp.cmp(written, correct)


def test_configure_invalid_tags(fileutils):
def test_configure_invalid_tags(fileutils, test_dir):
"""Test configure operation with an invalid tag"""
tagged_file = fileutils.get_test_conf_path(
osp.join("generator_files", "easy", "marked", "invalidtag.txt")
)
generator_files = pathlib.Path(fileutils.get_test_conf_path("generator_files"))
tagged_file = generator_files / "easy/marked/invalidtag.txt"
correct_file = generator_files / "easy/correct/invalidtag.txt"
target_file = pathlib.Path(test_dir, "target.txt")

tag = ";"
param_dict = {"VALID": "valid"}
Expand All @@ -560,11 +561,12 @@ def test_configure_invalid_tags(fileutils):
# Encode the pickled dictionary with Base64
encoded_dict = base64.b64encode(pickled_dict).decode("ascii")
parser = get_parser()
cmd = f"configure {tagged_file} {tagged_file} {tag} {encoded_dict}"
cmd = f"configure {tagged_file} {target_file} {tag} {encoded_dict}"
args = cmd.split()
ns = parser.parse_args(args)

file_operations.configure(ns)
assert filecmp.cmp(correct_file, target_file)


def test_configure_not_absolute():
Expand Down