Refactor of Generation class and inject path into Launch process #650
Conversation
REBASEME: moar mpi REBASEME: fmt mpi
MattToast
left a comment
MattToast
left a comment
There was a problem hiding this comment.
Some more philosophy question I wanted to throw your way before I started looking at this too in depth. Let me know what you think!
Otherwise, I think this starting to look about ready to me!
smartsim/experiment.py
Outdated
| """ | ||
| return self._dispatch(dispatch.DEFAULT_DISPATCHER, *jobs) | ||
| run_id = datetime.datetime.now().replace(microsecond=0).isoformat() | ||
| """Create the run id""" |
There was a problem hiding this comment.
I think for function variables it may be more natural for the comments to come before the variable if they are going to be added. I'm not seeing in vscode that they render as a comment
There was a problem hiding this comment.
If we are going to put these comments ahead of the variable as non-docstrings, can we make these look like traditional comments?
| """Create the run id""" | |
| # Create the run id |
In theory it makes saves us a no-op instruction at runtime, but in practice I just think it looks nicer, hahaha
smartsim/experiment.py
Outdated
| """ | ||
| job_type = f"{job.__class__.__name__.lower()}s" | ||
| job_path = pathlib.Path(root) / f"{job_type}/{job.name}-{job_index}" | ||
| job_path.mkdir(exist_ok=True, parents=True) |
There was a problem hiding this comment.
I think we need to make a ticket to inject a launcher in here. I think we want to use the entrypoints to enable remote jobs.
mellis13
left a comment
mellis13
left a comment
There was a problem hiding this comment.
Thanks for working on this -- just a couple of questions/comments
MattToast
left a comment
MattToast
left a comment
There was a problem hiding this comment.
A couple of small docstring nits, and one outstanding "TODO" style comment, but definitely nothing worth holding approval up over.
LGTM!! Thanks for all the hard work on this one!
smartsim/experiment.py
Outdated
| """ | ||
| return self._dispatch(dispatch.DEFAULT_DISPATCHER, *jobs) | ||
| run_id = datetime.datetime.now().replace(microsecond=0).isoformat() | ||
| """Create the run id""" |
There was a problem hiding this comment.
If we are going to put these comments ahead of the variable as non-docstrings, can we make these look like traditional comments?
| """Create the run id""" | |
| # Create the run id |
In theory it makes saves us a no-op instruction at runtime, but in practice I just think it looks nicer, hahaha
3 participants
No description provided.