-
Notifications
You must be signed in to change notification settings - Fork 26
Py39 updates #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Py39 updates #387
Conversation
2a81e66 to
a339e36
Compare
a339e36 to
dffb51c
Compare
|
Adding some notes. Numpy, >=1.20 does not support Python 3.6. This has the tandem effect of limiting scipy versions, and anything that might require these two, and so on. skimage is removed per #388 . That helps. pyfftw now has a PR which migrates to new python packaging format, along with some packaging depend changes. I hope that will install the required cython that pip needs to build from source. Eventually they will also make a 3.9 wheel. This leads to the last issue I encountered... there is some potential for compatibility issues between older numpy with newer pyfftw and vice versa. It looks something like below. This was latest pyfftw with numpy 1.19. Goes away with numpy 1.20. Will need to check that out again when they've moved... |
|
Noting that PyFFTW has recently merged their |
|
Checking up on this, still waiting on PyFFTW to support 3.9. Maybe our next release (they don't release too often). The changes/conflicts here are relatively minor, nothing to worry about. |
|
Planning to discuss this today, but I think because this PR is sufficiently conlficted/stale (and is easier to just redo) I will move to close this PR and start a fresh one following some discussion. Today I can split this into three topics, the bulk 3.9 support changes (int, float replacements), package version changes, and the pyfftw which was being discussed by their maintainers yesterday... |
|
Makes sense to me. |
Potential updates to support Python 3.9 and update some of our numerical packages.
We're still dependent on PyFFTW to either make a 3.9 wheel, or fix their packaging so we can pip install from source. It is possible for us to work around that if it becomes essential. I reported the issue to them, and I think their developers are looking into it. They have seen it a few times now... so I suggest we wait before we workaround in our packaging.
Closes #320