Skip to content

Conversation

@garrettwrong
Copy link
Collaborator

Later versions of Numpy, such as those used commonly upstream in Python 3.9, have made some changes to dtypes. The main ways this effects us are that np.int is deprecated in favor of int, and also np.float is deprecated in favor of float or a specific numpy type (like np.float64).

Those cases have been replaced in this PR.

Related to #387 and #320 .

@garrettwrong garrettwrong self-assigned this Sep 9, 2021
@garrettwrong garrettwrong requested a review from janden as a code owner September 9, 2021 15:27
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #454 (9b5ac4b) into develop (b893bef) will increase coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #454      +/-   ##
===========================================
+ Coverage    87.87%   88.15%   +0.27%     
===========================================
  Files          105      105              
  Lines         7530     7716     +186     
===========================================
+ Hits          6617     6802     +185     
- Misses         913      914       +1     
Impacted Files Coverage Δ
src/aspire/basis/fb_2d.py 98.97% <100.00%> (ø)
src/aspire/basis/fb_3d.py 100.00% <100.00%> (ø)
src/aspire/basis/ffb_2d.py 98.38% <100.00%> (ø)
...rc/aspire/classification/legacy_implementations.py 100.00% <100.00%> (ø)
src/aspire/ctf/ctf_estimator.py 98.87% <100.00%> (ø)
src/aspire/operators/blk_diag_matrix.py 96.01% <100.00%> (+1.08%) ⬆️
src/aspire/reconstruction/mean.py 100.00% <100.00%> (ø)
src/aspire/source/image.py 95.75% <100.00%> (+0.26%) ⬆️
src/aspire/source/simulation.py 99.46% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b893bef...9b5ac4b. Read the comment docs.

@garrettwrong garrettwrong merged commit da4d44c into develop Sep 10, 2021
@garrettwrong garrettwrong deleted the py_39_np_updates branch September 22, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants