remove unused skimage #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janden
approved these changes
Feb 18, 2021
Collaborator
janden
left a comment
janden
left a comment
There was a problem hiding this comment.
Before we remove, can we find the commit where skimage was last used?
Collaborator
Author
|
@janden , as best I can tell: never in this repo... First I checked the legacy src/aspire/aspire. It was not there. So then I asked git history... compare with This may be held over from the older ASPIRE python attempts? I do not recall why we could not remove it before, but I do remember it coming up. While this is unsatisfying, I think it is safe to merge the change. |
Collaborator
|
That is very strange. Maybe it was an aspirational dependency. I agree. Safe to remove. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might help with the py 39 installs.